Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-29 Thread Charles C. Berry
The changes have been pushed to master just now. To recap, inline src blocks and babel calls will now wrap their output in a `results' macro following the src block or call, replacing any previous such macro. `:results raw' prevents the wrapping from taking place. If the RESULT is a list o

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-24 Thread Charles C. Berry
On Sat, 24 Jan 2015, Aaron Ecay wrote: Hi Chuck, 2015ko urtarrilak 24an, "Charles C. Berry"-ek idatzi zuen: All tests passed (modulo a few shell and fortran issues unique to my setup which also failed for master). Then I did an update and `git merge master' and got a pile of errors due to

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-24 Thread Aaron Ecay
Hi Chuck, 2015ko urtarrilak 24an, "Charles C. Berry"-ek idatzi zuen: > All tests passed (modulo a few shell and fortran issues unique to my setup > which also failed for master). > > Then I did an update and `git merge master' and got a pile of errors due to > >commit fda70440f49292197d76ce

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-24 Thread Charles C. Berry
On Thu, 22 Jan 2015, Nicolas Goaziou wrote: "Charles C. Berry" writes: I attach 3 patches and a file of usage examples. Thanks. [delete - numerous pointers to small issues] This looks good. I think you can push them into master once the minor issues above are fixed and if all tests pa

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-22 Thread Nicolas Goaziou
"Charles C. Berry" writes: > I attach 3 patches and a file of usage examples. Thanks. > +(let* ((el (org-element-context)) > +(beg (org-element-property :begin el)) > +(type (org-element-type el))) > + (when (eq type 'inline-babel-call) > + (goto-char beg))) Nitpic

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-21 Thread Charles C. Berry
On Tue, 20 Jan 2015, Nicolas Goaziou wrote: "Charles C. Berry" writes: This is probably the shortest path. I'd apprecaite it if you would refactor that part. I implemented `org-macro-escape-arguments' which can replace your initial snippet: Nicolas, Thank you! I attach 3 patches and a

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-20 Thread Nicolas Goaziou
"Charles C. Berry" writes: > This is probably the shortest path. I'd apprecaite it if you would > refactor that part. I implemented `org-macro-escape-arguments' which can replace your initial snippet: + ;; Escape commas and preceding backslash per + ;; (info "

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-19 Thread Charles C. Berry
On Mon, 19 Jan 2015, Nicolas Goaziou wrote: "Charles C. Berry" writes: Thanks for the patches. Here's another round of comments. OK. Now those cases (and some others) insert `*Inline error:' and a comment as to what the error is and ignore the actual value. Based on my own experience, I tho

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-19 Thread Nicolas Goaziou
"Charles C. Berry" writes: Thanks for the patches. Here's another round of comments. > OK. Now those cases (and some others) insert `*Inline error:' and a > comment as to what the error is and ignore the actual value. > > Based on my own experience, I thought it best to allow Babel to run > with

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-18 Thread Charles C. Berry
On Fri, 16 Jan 2015, Nicolas Goaziou wrote: "Charles C. Berry" writes: I've attached three patches and two files that show the behavior under the current master (12 Jan 2015, e0879b03d08bb4acc663084076370482f61e8698) and under the patched version. Thank you. Some comments follow. [snip]

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-18 Thread Aaron Ecay
Hi Nicolas, 2015ko urtarrilak 18an, Nicolas Goaziou-ek idatzi zuen: > > Aaron Ecay writes: > >> 2015ko urtarrilak 17an, Nicolas Goaziou-ek idatzi zuen: >>> It would be more flexible, but it would also defeat the whole point of >>> the "results" macro, that is to be able to mark /unambiguously/

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-18 Thread Nicolas Goaziou
Aaron Ecay writes: > 2015ko urtarrilak 17an, Nicolas Goaziou-ek idatzi zuen: >> It would be more flexible, but it would also defeat the whole point of >> the "results" macro, that is to be able to mark /unambiguously/ the >> output of an inline block. Indeed, even if you can get the name of the >

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-18 Thread Aaron Ecay
Hi Nicolas, 2015ko urtarrilak 17an, Nicolas Goaziou-ek idatzi zuen: > It would be more flexible, but it would also defeat the whole point of > the "results" macro, that is to be able to mark /unambiguously/ the > output of an inline block. Indeed, even if you can get the name of the > macro from t

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-17 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: >> (funcall wrap (concat "#+BEGIN_" name) >> - (concat "#+END_" (car (org-split-string name)) >> + (concat "#+END_" (car (org-split-string name))) >> + nil nil (concat "{{{resul

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-16 Thread Aaron Ecay
Hi Chuck, Thanks for the patches. I agree with Nicolas about the issue of multi-line results for inline blocks. I think he already raised any comments I would have made about the code. Additional comments about broader issues: 2015ko urtarrilak 12an, "Charles C. Berry"-ek idatzi zuen: > (defu

Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-16 Thread Nicolas Goaziou
"Charles C. Berry" writes: > I've attached three patches and two files that show the behavior under > the current master (12 Jan 2015, > e0879b03d08bb4acc663084076370482f61e8698) and under the patched > version. Thank you. Some comments follow. > With the patches, inline source block results ca

[O] New patches WAS Re: [PATCH] inline src block results can be removed

2015-01-12 Thread Charles C. Berry
On Sun, 16 Nov 2014, Nicolas Goaziou wrote: "Charles C. Berry" writes: For now, I'd be willing to make patches that will allow removal of the inline src block results that do *not* involve these header args: - :file - :wrap - :results latex html drawer org code which I can do barely touch