Re: [O] Fix org.el compilation warnings

2017-05-26 Thread Kaushal Modi
On Fri, May 26, 2017, 4:45 PM Kyle Meyer wrote: > > When I run byte-compile-file on org.el (no Org loaded, with master's Org > first on the load-path), I don't see any of the above warnings aside > from the one for org-agenda-include-inactive-timestamps, which is fixed > by the patch. And becaus

Re: [O] Fix org.el compilation warnings

2017-05-26 Thread Kyle Meyer
Kaushal Modi writes: >> Ah, right ... 'make compile' uses a single Emacs instance, while 'make >> single' uses a separate Emacs instance for each file. > > I wasn't even doing that. I was doing M-x byte-compile-file and selecting > org.el. Sure, I was just noting why I didn't see the org-agenda-

Re: [O] Fix org.el compilation warnings

2017-05-26 Thread Kaushal Modi
Below update is after I updated to the latest org master: On Thu, May 25, 2017 at 10:53 PM Kyle Meyer wrote: > Ah, right ... 'make compile' uses a single Emacs instance, while 'make > single' uses a separate Emacs instance for each file. > I wasn't even doing that. I was doing M-x byte-compile-

Re: [O] Fix org.el compilation warnings

2017-05-25 Thread Kyle Meyer
Kaushal Modi writes: > On Thu, May 25, 2017, 7:59 PM Kyle Meyer wrote: > >> Kaushal Modi writes: >> >> > I was trying to fix the org.el compilation warnings. >> >> I don't see any compiler warnings when I run 'make compile' with either >> master (2960dc971) or maint (89bd7ad87) on Emacs 25.2. >

Re: [O] Fix org.el compilation warnings

2017-05-25 Thread Kaushal Modi
On Thu, May 25, 2017, 7:59 PM Kyle Meyer wrote: > Kaushal Modi writes: > > > I was trying to fix the org.el compilation warnings. > > I don't see any compiler warnings when I run 'make compile' with either > master (2960dc971) or maint (89bd7ad87) on Emacs 25.2. > Those warnings were on master

Re: [O] Fix org.el compilation warnings

2017-05-25 Thread Kyle Meyer
Kaushal Modi writes: > I was trying to fix the org.el compilation warnings. I don't see any compiler warnings when I run 'make compile' with either master (2960dc971) or maint (89bd7ad87) on Emacs 25.2. -- Kyle

[O] Fix org.el compilation warnings

2017-05-25 Thread Kaushal Modi
Hello, I was trying to fix the org.el compilation warnings. I could fix just this one: >From 4e2de052dd05e66ed71ce070e4413859e2c13238 Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Thu, 25 May 2017 18:24:34 -0400 Subject: [PATCH] org: Silence byte-compiler * lisp/org.el (org-agenda-include-