Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
On Mon, Apr 17, 2017 at 2:05 PM Nicolas Goaziou wrote: > This was a typo of mine. Fixed. Thank you. > > Regards, > Thanks. I confirm the fix. -- Kaushal Modi

Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Nicolas Goaziou
Hello, Kaushal Modi writes: > While that error is fixed, we still have this byte compilation warning: > > org-capture.el:1586:1:Warning: Unused lexical variable ‘first-value’ > > I haven't used pcase extensively, but based on the warning, the below > doesn't work as intended in the compiled elc:

Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
While that error is fixed, we still have this byte compilation warning: org-capture.el:1586:1:Warning: Unused lexical variable ‘first-value’ I haven't used pcase extensively, but based on the warning, the below doesn't work as intended in the compiled elc: ((or "C" "L") (let ((insert-fun

Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
This patch works: >From 5edec74298a0140c5ebf55e7be0d64de6c702b17 Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Mon, 17 Apr 2017 11:01:28 -0400 Subject: [PATCH] Fix nil case in pcase * lisp/org-capture.el (org-capture-fill-template): Use `nil for the nil case in pcase form. --- lisp/org-ca

Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
To add, I am using emacs build from the master branch as of today. Doing M-x byte-compile-file on org-capture.el gives: - Compiling file /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-capture.el at Mon Apr 17 10:48:22 2017 org-capture.el:1586:1:Error: Unknown pattern ‘nil’ - On Mon, Apr 1

[O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
I am on master branch: ea3754f. A recent change in org-capture.el breaks compilation: In toplevel form: org-capture.el:1586:1:Error: Unknown pattern ‘nil’ Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-install.el... Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-loaddefs.el... Com