Re: [O] Draft of links-9.0

2016-07-05 Thread John Kitchin
Thanks for the feedback. Here is a second round of revised commits. I addressed the comments you made. I have not pushed these to the branch yet. Let me know what you think about these. Thanks for the help! commit f5bcdaac6e3d4507c934b8872c4a53c4d90e9143 Author: John Kitchin Date: Tue Jul 5 10

Re: [O] Draft of links-9.0

2016-07-05 Thread Nicolas Goaziou
John Kitchin writes: > I pasted the diffs at the end. There are a lot because it touched a lot of > files, and I committed each one separately, and forgot a few commits > that ended up as extras. Probably some could be combined and squashed if > that is desirable. I am not sure how to do it yet t

Re: [O] Draft of links-9.0

2016-07-05 Thread John Kitchin
Nicolas Goaziou writes: > Hello, > > John Kitchin writes: > >> I have completed a draft of links-9.0 >> (https://github.com/jkitchin/org-mode/tree/link-9.0). This centralizes >> almost all link properties into a variable `org-link-parameters' and >> makes it possible to customize almost everythi

Re: [O] Draft of links-9.0

2016-07-05 Thread Nicolas Goaziou
Completing myself, Nicolas Goaziou writes: > It is better to create a new function, e.g., `org-link-add' with the > following signature > > (defun org-link-add (type &rest properties) >...) > > used like > > (org-link-add "red" :follow (lambda (path desc backend) ...) :export ) Basi

Re: [O] Draft of links-9.0

2016-07-05 Thread Nicolas Goaziou
Hello, John Kitchin writes: > I have completed a draft of links-9.0 > (https://github.com/jkitchin/org-mode/tree/link-9.0). This centralizes > almost all link properties into a variable `org-link-parameters' and > makes it possible to customize almost everything in the link. Thank you. > which

[O] Draft of links-9.0

2016-07-05 Thread John Kitchin
Hi all, I have completed a draft of links-9.0 (https://github.com/jkitchin/org-mode/tree/link-9.0). This centralizes almost all link properties into a variable `org-link-parameters' and makes it possible to customize almost everything in the link. This branch passes all the tests except these: 2