Re: [O] Add preamble support to ob-plantuml.el

2016-12-10 Thread Nicolas Goaziou
Thibault Marin writes: > Please find attached a patch updating ORG-NEWS. Perfect. Applied. Thank you. Regards,

Re: [O] Add preamble support to ob-plantuml.el

2016-12-10 Thread Thibault Marin
Hi, Please find attached a patch updating ORG-NEWS. Thanks, thibault >From 3d335b093d4e95b14cc71317d2aef024f1c64fd5 Mon Sep 17 00:00:00 2001 From: thibault Date: Sat, 10 Dec 2016 08:27:48 -0600 Subject: [PATCH] * etc/ORG-NEWS: Header arguments support for PlantUML source blocks --- etc/ORG-N

Re: [O] Add preamble support to ob-plantuml.el

2016-12-10 Thread Nicolas Goaziou
Hello, Thibault Marin writes: > The attached patch removes the useless definition of > `org-babel-plantuml-var-to-plantuml' (the regexp is moved to the > `org-babel-variable-assignments:plantuml' function) but keeps the > `org-babel-plantuml-make-body' function, useful for testing. Fair enough.

Re: [O] Add preamble support to ob-plantuml.el

2016-12-09 Thread Thibault Marin
Hi, Nicolas Goaziou writes: > Comments follow. > >> +(defun org-babel-plantuml-var-to-plantuml (var) >> + "Cleanup plantuml variable (remove quotes)." >> + (replace-regexp-in-string "\"" "" var)) > > Since this function is used only once in the code, I suggest to not > implement it and use `

Re: [O] Add preamble support to ob-plantuml.el

2016-12-09 Thread Nicolas Goaziou
Hello, Thibault Marin writes: > However, ob-plantuml does not seem to support the prologue option. So I > am modifying my patch to add support for the :prologue and :epilogue > header arguments instead of using a new customization variable. In the > process, I have added support for header var

Re: [O] Add preamble support to ob-plantuml.el

2016-12-06 Thread Thibault Marin
Thanks for the feedback. >> What about using noweb syntax then? > > Or prologue? I didn't know about the prologue header. This is exactly what I need (it seems to be more convenient than the noweb approach). However, ob-plantuml does not seem to support the prologue option. So I am modifying

Re: [O] Add preamble support to ob-plantuml.el

2016-12-06 Thread Rainer M Krug
Nicolas Goaziou writes: > Thibault Marin writes: > >> I use it to define common skin options (http://plantuml.com/skinparam) >> for all the plantuml blocks in an org file. I don't know if there is a >> better way to that. > > What about using noweb syntax then? Or prologue? , | 14.8.2.28

Re: [O] Add preamble support to ob-plantuml.el

2016-12-06 Thread Nicolas Goaziou
Thibault Marin writes: > I use it to define common skin options (http://plantuml.com/skinparam) > for all the plantuml blocks in an org file. I don't know if there is a > better way to that. What about using noweb syntax then? Regards,

Re: [O] Add preamble support to ob-plantuml.el

2016-12-05 Thread Thibault Marin
Hi, thanks for the feedback. > You don't need to use the TINYCHANGE string since you signed FSF papers > already. Fixed. > The :version keyword is inaccurate. It should be :version "25.2". It is > also missing :package-version and :safe #'stringp. Fixed (I hope). > OOC, what is your use case? I

Re: [O] Add preamble support to ob-plantuml.el

2016-12-05 Thread Nicolas Goaziou
Hello, Thibault Marin writes: > I am attaching a patch adding support for preamble commands to > ob-plantuml.el. The string content of the `org-plantuml-preamble' > variable is added at the beginning of each source block before execution > (after the "@startuml" string). Thank you. Some commen

[O] Add preamble support to ob-plantuml.el

2016-12-01 Thread Thibault Marin
Hi list, I am attaching a patch adding support for preamble commands to ob-plantuml.el. The string content of the `org-plantuml-preamble' variable is added at the beginning of each source block before execution (after the "@startuml" string). Does this look like this could be merged? Please le