Re: [O] [patch] Improved block insertion

2018-04-08 Thread Nicolas Goaziou
Rasmus writes: > I have fixed up the patches. Great! > Ha, actually I used pcase at first but then changed it to something more > simple. Are there any performance issues with pcase or can it be used > unconditionally? It can be used unconditionally. > Any worries about pushing the patches n

Re: [O] [patch] Improved block insertion

2018-04-08 Thread Rasmus
Hi, Thanks for the comments! I have fixed up the patches. > I don't think the old key-binding should be kept. OK. > Suggestion: > > (key (pcase (read-char-exclusive prompt) > ((or ?\s ?\t ?\r) ?\t) > (char char))) Ha, actually I used pcase at first but then changed it to

Re: [O] [patch] Improved block insertion

2018-04-08 Thread Nicolas Goaziou
Hello, Rasmus writes: > These patches improve the block insertion mechanisms using both the > keyboard binding and org-tempo. Thank you. Some quick comments follow. > Patch 6 changes the key binding of blocks to "C-c C-," as discussed in > December 2017. Let me know if this key is OK and if t

[O] [patch] Improved block insertion

2018-04-07 Thread Rasmus
Hi, These patches improve the block insertion mechanisms using both the keyboard binding and org-tempo. I first sent these patches at Christmas, but did not have time to finish them due to unexpected events. On the Tempo side the cursor placement is a bit more clever. For an "empty" source bloc