Re: [O] [patch] Don't output preamble DIV if its contents is empty

2011-10-29 Thread Bastien
Hi Sébastien, "Sebastien Vauban" writes: > Question: why do we do like that (inserting the ChangeLog contents after the > first line of the commit log)? Is it automatically used somewhere to generate > a proper ChangeLog file? Yes -- see UTILITIES/make_emacs_changelog which collects logs from

Re: [O] [patch] Don't output preamble DIV if its contents is empty

2011-10-29 Thread Sebastien Vauban
Hi Bastien, Bastien wrote: > "Sebastien Vauban" writes: >>> are there adverse effects when an empty div is in the file? >> >> Yes, there are, reason for such patch. > > I understand the reasons and I have applied the patch -- please provide a > ChangeLog next time. I can assure you that I'll do,

Re: [O] [patch] Don't output preamble DIV if its contents is empty

2011-10-29 Thread Bastien
Hi Sébastien, "Sebastien Vauban" writes: >> are there adverse effects when an empty div is in the file? > > Yes, there are, reason for such patch. I understand the reasons and I have applied the patch -- please provide a ChangeLog next time. You can provide it like you just did (with the tag

Re: [O] [patch] Don't output preamble DIV if its contents is empty

2011-10-09 Thread Sebastien Vauban
Hi Carsten, Carsten Dominik wrote: >> To be sure that CSS rules don't apply to missing contents, there's no need >> to output DIV preamble opening and closing tags if there is nothing in >> between. > > are there adverse effects when an empty div is in the file? Yes, there are, reason for such pa

Re: [O] [patch] Don't output preamble DIV if its contents is empty

2011-10-09 Thread Carsten Dominik
Hi Sebastien, are there adverse effects when an empty div is in the file? THanks - Carsten On 29.9.2011, at 21:58, Sebastien Vauban wrote: > Hi, > > To be sure that CSS rules don't apply to missing contents, there's no need to > output DIV preamble opening and closing tags if there is nothing

[O] [patch] Don't output preamble DIV if its contents is empty

2011-09-29 Thread Sebastien Vauban
Hi, To be sure that CSS rules don't apply to missing contents, there's no need to output DIV preamble opening and closing tags if there is nothing in between. Best regards, Seb -- Sebastien Vauban >From 9bb3959f8ca978e7486ba7bde11cd407a40e653b Mon Sep 17 00:00:00 2001 From: Sebastien Vauban