Re: [O] [babel][PATCHES] ob-R patches for review

2014-06-06 Thread Eric Schulte
>> Additionally, if the variables simply hold R code text, then users can >> easily initialize them from R files locally with something like the >> following. >> >> (setq org-babel-R-assign-elisp-function >> (with-temp-buffer >> (insert-file-contents-literally "personal.R"

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-16 Thread Charles C. Berry
On Fri, 16 May 2014, Rainer M Krug wrote: Sorry for coming back to your suggestions so late, but I did some thinking about the approach. Comments inline below. No problem. I am about to leave town and my email for a couple of weeks, so I might not be able to reply to further correspondence til

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Charles C. Berry
On Mon, 12 May 2014, Rainer M Krug wrote: Eric Schulte writes: If not would you mind submitting a version of the patches split into multiple commits with as much of the hard-coded R code as feasible placed into customizable variables along the lines of the `org-babel-R-assign-elisp-function'

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Rainer M Krug
Eric Schulte writes: >>> If not would you mind submitting a version of the patches split into >>> multiple commits with as much of the hard-coded R code as feasible >>> placed into customizable variables along the lines of the >>> `org-babel-R-assign-elisp-function' variable suggested by Charles.

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Eric Schulte
>> If not would you mind submitting a version of the patches split into >> multiple commits with as much of the hard-coded R code as feasible >> placed into customizable variables along the lines of the >> `org-babel-R-assign-elisp-function' variable suggested by Charles. > > I am thinking of act

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Rainer M Krug
Suvayu Ali writes: > On Mon, May 12, 2014 at 10:33:48AM +0200, Rainer M Krug wrote: >> Eric Schulte writes: >> >> > Rainer M Krug writes: >> > >> >> Bastien writes: >> >> >> >>> Hi Rainer, >> >>> >> >>> Rainer M Krug writes: >> >>> >> I'll look at it again tomorrow and let you know as I

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Suvayu Ali
On Mon, May 12, 2014 at 10:33:48AM +0200, Rainer M Krug wrote: > Eric Schulte writes: > > > Rainer M Krug writes: > > > >> Bastien writes: > >> > >>> Hi Rainer, > >>> > >>> Rainer M Krug writes: > >>> > I'll look at it again tomorrow and let you know as I made some changes > since th

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Rainer M Krug
Eric Schulte writes: > Rainer M Krug writes: > >> Bastien writes: >> >>> Hi Rainer, >>> >>> Rainer M Krug writes: >>> I'll look at it again tomorrow and let you know as I made some changes since then. Do you prefer one patch to several? >>> >>> Up to Eric's taste -- but in general I

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Eric Schulte
Rainer M Krug writes: > Bastien writes: > >> Hi Rainer, >> >> Rainer M Krug writes: >> >>> I'll look at it again tomorrow and let you know as I made some changes >>> since then. Do you prefer one patch to several? >> >> Up to Eric's taste -- but in general I think a series of patches >> is bett

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Rainer M Krug
Bastien writes: > Hi Rainer, > > Rainer M Krug writes: > >> I'll look at it again tomorrow and let you know as I made some changes >> since then. Do you prefer one patch to several? > > Up to Eric's taste -- but in general I think a series of patches > is better, it allows you to isolate and fix

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Bastien
Hi Rainer, Rainer M Krug writes: > I'll look at it again tomorrow and let you know as I made some changes > since then. Do you prefer one patch to several? Up to Eric's taste -- but in general I think a series of patches is better, it allows you to isolate and fix conflicts more easily. -- B

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Rainer M Krug
Rainer M Krug writes: > Rainer M Krug writes: > >> Envoyé de mon iPhone >> >>> Le 8 mai 2014 à 04:26, Charles Berry a écrit : >>> >>> Eric Schulte gmail.com> writes: >>> Rainer M Krug krugs.de> writes: > Hi > > Attached please find seven patches for review to i

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Rainer M Krug
Rainer M Krug writes: > Envoyé de mon iPhone > >> Le 8 mai 2014 à 04:26, Charles Berry a écrit : >> >> Eric Schulte gmail.com> writes: >> >>> >>> Rainer M Krug krugs.de> writes: >>> Hi Attached please find seven patches for review to implement the storing of org variab

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-08 Thread Rainer M Krug
Envoyé de mon iPhone > Le 8 mai 2014 à 04:26, Charles Berry a écrit : > > Eric Schulte gmail.com> writes: > >> >> Rainer M Krug krugs.de> writes: >> >>> Hi >>> >>> Attached please find seven patches for review to implement the storing >>> of org variables in their own environment and to

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-08 Thread Rainer M Krug
> Le 7 mai 2014 à 12:27, Eric Schulte a écrit : > > Rainer M Krug writes: > >> Hi >> >> Attached please find seven patches for review to implement the storing >> of org variables in their own environment and to make the org-issued R >> code look nicer in the R session. >> >> Thanks, >> >> R

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-07 Thread Charles Berry
Eric Schulte gmail.com> writes: > > Rainer M Krug krugs.de> writes: > > > Hi > > > > Attached please find seven patches for review to implement the storing > > of org variables in their own environment and to make the org-issued R > > code look nicer in the R session. > > > > Thanks, > > > > R

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-07 Thread Eric Schulte
Rainer M Krug writes: > Hi > > Attached please find seven patches for review to implement the storing > of org variables in their own environment and to make the org-issued R > code look nicer in the R session. > > Thanks, > > Rainer Hi Rainer, Thanks for these patches. I don't have the R expe

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-01 Thread Rainer M Krug
"Charles C. Berry" writes: > On Wed, 30 Apr 2014, Rainer M Krug wrote: > >> Charles Berry writes: >> >>> Rainer M Krug krugs.de> writes: >>> Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make t

Re: [O] [babel][PATCHES] ob-R patches for review

2014-04-30 Thread Charles C. Berry
On Wed, 30 Apr 2014, Rainer M Krug wrote: Charles Berry writes: Rainer M Krug krugs.de> writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the R session. Rainer,

Re: [O] [babel][PATCHES] ob-R patches for review

2014-04-30 Thread Rainer M Krug
Charles Berry writes: > Rainer M Krug krugs.de> writes: > >> >> Hi >> >> Attached please find seven patches for review to implement the storing >> of org variables in their own environment and to make the org-issued R >> code look nicer in the R session. > > > Rainer, > > > I have suggestions

Re: [O] [babel][PATCHES] ob-R patches for review

2014-04-29 Thread Charles Berry
Rainer M Krug krugs.de> writes: > > Hi > > Attached please find seven patches for review to implement the storing > of org variables in their own environment and to make the org-issued R > code look nicer in the R session. Rainer, I have suggestions and a concern. I suggest that you look a

[O] [babel][PATCHES] ob-R patches for review

2014-04-29 Thread Rainer M Krug
Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the R session. Thanks, Rainer -- Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (G