Re: [O] [PATCH 2/2] lisp/ob.el: Don't modify babel info when hashing it

2011-06-03 Thread Lawrence Mitchell
Eric Schulte wrote: > Hi Lawrence, > Is there a reason to make this copy? Given that params is used like a > hash/dictionary the order of it's elements should not matter. Is there > a case where this patch is necessary to avoid buggy behavior? Ah, but the sorting is happening so that the hashin

Re: [O] [PATCH 2/2] lisp/ob.el: Don't modify babel info when hashing it

2011-06-02 Thread Eric Schulte
Hi Lawrence, Is there a reason to make this copy? Given that params is used like a hash/dictionary the order of it's elements should not matter. Is there a case where this patch is necessary to avoid buggy behavior? If so then I'm happy to apply the patch, but if there is no need then I'd rathe

[O] [PATCH 2/2] lisp/ob.el: Don't modify babel info when hashing it

2011-06-02 Thread Lawrence Mitchell
* lisp/ob.el (org-babel-sha1-hash): Don't modify info argument by side-effect when sorting result-params list. copy-sequence only does shallow copies, so if we're going to modify a sub-list, we need to make sure we copy it first. --- lisp/ob.el |2 +- 1 files changed, 1 insertions(+), 1 delet