Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-08-04 Thread Bastien Guerry
Hi Brice, Nicolas Goaziou writes: > Brice Waegenire writes: > >> Following is ORG-NEWS entry: >> >> * Incompatible changes >> ** org-timer-default-timer type changed from number to string >> If you have, in your configuration, something like =(setq >> org-timer-default-timer 10)= replace it wit

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-06-06 Thread Nicolas Goaziou
Brice Waegenire writes: > Following is ORG-NEWS entry: > > * Incompatible changes > ** org-timer-default-timer type changed from number to string > If you have, in your configuration, something like =(setq > org-timer-default-timer 10)= replace it with =(setq > org-timer-default-timer "10")=. > *

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-06-03 Thread Brice Waegenire
Following is ORG-NEWS entry: * Incompatible changes ** org-timer-default-timer type changed from number to string If you have, in your configuration, something like =(setq org-timer-default-timer 10)= replace it with =(setq org-timer-default-timer "10")=. * New features ** Countdown timer support

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-06-02 Thread Nicolas Goaziou
Brice Waegenire writes: > Here is that version of this patch, at least I hope it is. Applied, Thank you. Would you mind preparing an entry in ORG-NEWS? Regards,

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-06-02 Thread Brice Waegenire
Sorry for the long delayed response. Here is that version of this patch, at least I hope it is. Yes I signed the papers, my number is #1011602. 2015-05-07 22:09 GMT+02:00 Nicolas Goaziou : > Brice Waegenire writes: > >> Thanks for help on this! >> Here is the last version of the patch taking int

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-05-07 Thread Nicolas Goaziou
Brice Waegenire writes: > Thanks for help on this! > Here is the last version of the patch taking into account all of your > comments. Thank you. >(read-from-minibuffer > - "How many minutes left? " > - (if (not (eq org-timer-default-timer

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-05-05 Thread Brice Waegenire
Thanks for help on this! Here is the last version of the patch taking into account all of your comments. 2015-05-01 10:47 GMT+02:00 Nicolas Goaziou : > Hello, > > Brice Waegenire writes: > >> I have took in consideration all of your points, is it better now? >> The current patch doesn't overwrit

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-05-01 Thread Nicolas Goaziou
Hello, Brice Waegenire writes: > I have took in consideration all of your points, is it better now? > The current patch doesn't overwrite the present behavior of > org-set-timer it only add the possibility to use hh:mm:ss format. Thank you. Some comments follow in addition to Kyle's. > From:

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-04-29 Thread Kyle Meyer
Brice Waegenire wrote: > I have took in consideration all of your points, is it better now? > The current patch doesn't overwrite the present behavior of > org-set-timer it only add the possibility to use hh:mm:ss format. Thanks. > From 8d6e379f3ed432511c613a0cf40804d2de1764b8 Mon Sep 17 00:00:0

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-04-29 Thread Brice Waegenire
I have took in consideration all of your points, is it better now? The current patch doesn't overwrite the present behavior of org-set-timer it only add the possibility to use hh:mm:ss format. 2015-04-24 18:49 GMT+02:00 Kyle Meyer : > Brice Waegenire wrote: >> Hello, >> >> I've hacked a patch th

Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-04-24 Thread Kyle Meyer
Brice Waegenire wrote: > Hello, > > I've hacked a patch that use hh:mm:ss format instead of minutes for > org-timer-set-timer. I'm really not sure I did it in the right way, > any sugestions are welcome. [...] Thanks. I think it's nice to be able to specify seconds, but now you have to type 'N:0

[O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

2015-04-24 Thread Brice Waegenire
Hello, I've hacked a patch that use hh:mm:ss format instead of minutes for org-timer-set-timer. I'm really not sure I did it in the right way, any sugestions are welcome. Both tests test-org-timer/set-timer andtest-org-timer/pause-timer where adapted to the new format. Brice. From 18bf5a0c3e2a11