Re: [O] [PATCH] org-table-beginning/end-of-field

2014-09-12 Thread Nicolas Goaziou
Hello, Florian Beck writes: Thanks for your feedback. > This I did. Well, (or (org-element-get 'table-cell) ;; Fuzzy matching when on a table border: (org-element-get 'table-cell (1+ (point))) (org-element-get 'table-cell (1- (point is not necessary, since the first

Re: [O] [PATCH] org-table-beginning/end-of-field

2014-09-10 Thread Florian Beck
Nicolas Goaziou writes: > the next (or maybe previous) cell. You may want to try > `org-element-context' in the following places, where X denotes cursor: > > | a | b | > X c | d | > > X a | b | > | c | d | This I did. > X | a | b | > | c | d | > > | a | b | X > | c | d | > > |

Re: [O] [PATCH] org-table-beginning/end-of-field

2014-09-10 Thread Nicolas Goaziou
Hello, Florian Beck writes: > I hope the new version is an improvement. Thanks for the update. > But as long as I have a table cell ancestor, I should be fine. Am > I missing something? Yes. There are some place where `org-element-context' will return a `table-row' or `table' object even thou

Re: [O] [PATCH] org-table-beginning/end-of-field

2014-09-09 Thread Florian Beck
Hi Nicolas, thanks for the review. I hope the new version is an improvement. Nicolas Goaziou writes: > Also, note that you can avoid requiring MOVE-FN, ELEMENT and CMP-FN if > you decide that > > (< n 0) => (#'org-table-next-field :contents-end #'<=) > (> n 0) => (#'org-table-previous-fie

Re: [O] [PATCH] org-table-beginning/end-of-field

2014-09-08 Thread Nicolas Goaziou
Florian Beck writes: > How about this? Nice. Some comments follow. > > From 4fb2bbff2238d15ae7c896e0eb268b74ea4e56dc Mon Sep 17 00:00:00 2001 > From: Florian Beck > Date: Mon, 8 Sep 2014 14:08:56 +0200 > Subject: [PATCH] org-table: fix arguments of `org-table-beginning-of-field' "fix" needs to

Re: [O] [PATCH] org-table-beginning/end-of-field

2014-09-08 Thread Florian Beck
Nicolas Goaziou writes: > Thanks for the patch. Though, wouldn't it make more sense to properly > handle a missing argument instead? How about this? -- Florian Beck >From 4fb2bbff2238d15ae7c896e0eb268b74ea4e56dc Mon Sep 17 00:00:00 2001 From: Florian Beck Date: Mon, 8 Sep 2014 14:08:56 +0200