Hello,
> Sure! Revised patch attached updates docstrings and adds ORG-NEWS.
>
> I also added more test cases and fixed a few small edge cases (ex:
> org-capture with just a template, no links). I reworded the
> documentation strings to pass M-x checkdoc as well. =)
Great !
Applied. Thank you.
Nicolas Goaziou writes:
Hello, Nicolas!
> Apparently, there is no more feedback, so I think it's good to go.
> One minor issue, however: could you check that sentences (in comments
> and docstrings) are always separated by two spaces?
> Also, would you mind providing an entry for ORG-NEWS?
Sur
Hello,
Sacha Chua writes:
> Following up on this patch. Do you need anything else from me before you
> merge this? What happens next? =)
Apparently, there is no more feedback, so I think it's good to go.
One minor issue, however: could you check that sentences (in comments
and docstrings) are
Sacha Chua writes:
Hello, all!
> On second thought, your suggestion for always unhexifying makes the
> calls from the other handlers simpler, so I've attached a corrected patch.
Following up on this patch. Do you need anything else from me before you
merge this? What happens next? =)
Sacha
Sacha Chua writes:
Hello, Aaron, all!
> Beats me, but the previous implementation made it a separate parameter
> for org-protocol-split-data, so I figured I'd carry it upwards into this
...
> Same notes as for hexify. Probably okay either way, but I don't know
> enough about who else uses this c
Aaron Ecay writes:
Hello, Aaron, all!
> API change to remove the ‘new-style’ arguments from these functions.
> I don’t have any clever ideas to solve this, and it’s not an objection
How about this approach? If it's new-style, we pass the new-style
property list as the only parameter to the org-
Hi Sacha,
Thanks for the patch. It looks great!
I assume eventually we will want to deprecate the old-style links, and
make new-style the only style. Unfortunately, this would mean another
API change to remove the ‘new-style’ arguments from these functions.
I don’t have any clever ideas to solv
Aaron Ecay writes:
Hello, Aaron, Rasmus, all!
> better solution IMO would be to make org-protocol links valid urls in
> another way, using the query string format:
> org-protocol://store-link?url=[...]&title=[...]
Aaron: Great point! I've changed my code to support this style of
org-protocol li
