Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check

2014-10-16 Thread Nicolas Goaziou
Kyle Meyer writes: > Nice. Thanks for fixing my fixes. Patch applied. Thank you. Regards,

Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check

2014-10-16 Thread Kyle Meyer
Nicolas Goaziou wrote: > Kyle Meyer writes: > Actually, it doesn't work either. Under some circumstances (e.g, when > p is a drawer name and q is "t"), q will have precedence over p, which > is not desirable. Good point. > What about this? > > (cond ((equal p "nil") nil) > ((equal p "

Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check

2014-10-16 Thread Nicolas Goaziou
Kyle Meyer writes: > This new patch should handle that correctly. Thanks. > (cond > - ((or (not (or p q)) (equal p "nil") (equal q "nil")) > org-clock-into-drawer) > - ((or (equal p "t") (equal q "t")) "LOGBOOK") > - ((not p) q) > - (t p > + ((not (or p q)) org-clo

Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check

2014-10-16 Thread Kyle Meyer
Kyle Meyer wrote: > Nicolas Goaziou wrote: >> This is wrong. >> >> If p is a string, e.g. "FOO", return value should be "FOO". Ditto if >> q contains a string. > > Right. Thanks for pointing that out. I'll update the patch. This new patch should handle that correctly. >From 84799f9b9f4a2e89b3e7

Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check

2014-10-16 Thread Kyle Meyer
Nicolas Goaziou wrote: > This is wrong. > > If p is a string, e.g. "FOO", return value should be "FOO". Ditto if > q contains a string. Right. Thanks for pointing that out. I'll update the patch.

Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check

2014-10-16 Thread Nicolas Goaziou
Hello, Kyle Meyer writes: > A question on Stack Overflow [1] reported an issue overriding > `org-clock-into-drawer' with properties (specifically, overriding a > global value of t with a property value nil). Looking into the function > `org-clock-into-drawer', the actual behavior did not match t

[O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check

2014-10-16 Thread Kyle Meyer
Hello, A question on Stack Overflow [1] reported an issue overriding `org-clock-into-drawer' with properties (specifically, overriding a global value of t with a property value nil). Looking into the function `org-clock-into-drawer', the actual behavior did not match the documented behavior. The a