Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-07 Thread Nicolas Goaziou
Hello, Christian Garbs writes: > I fear that I am the only one who will ever run the vala tests ;-) > > - Are there any build hosts that automatically run the tests with all > languages enabled? I don't think so. > - Or could the BTEST_OB_LANGUAGES default in mk/default.mk be expanded > to

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-06 Thread Christian Garbs
Hello On Sun, Aug 06, 2017 at 02:22:31AM +0200, Nicolas Goaziou wrote: > Christian Garbs writes: > > Currently I run into a problem with the test case: I have created an > > org file containing some Vala code and an .el file with some tests, > > It would be better to have all tests and data se

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-05 Thread Nicolas Goaziou
Hello, Christian Garbs writes: > Byte-compiling works and gave me 5 warnings about unused variables and > arguments which I could fix in different ways. Note that the usual solution to get rid of unused arguments is to prefix their name with "_". > Currently I run into a problem with the test

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-05 Thread Christian Garbs
Hi! On Thu, Aug 03, 2017 at 12:49:44PM +0200, Nicolas Goaziou wrote: > Christian Garbs writes: > > Regarding the lexical-binding: How can I check if byte-compiling is > > successful? > > M-x emacs-lisp-byte-compile Byte-compiling works and gave me 5 warnings about unused variables and argumen

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-03 Thread Nicolas Goaziou
Hello, Christian Garbs writes: > The next iteration of the patch should include ob-vala.el itself, some > tests and an ORG-NEWS entry. Great! Thank you. > Regarding the lexical-binding: How can I check if byte-compiling is > successful? M-x emacs-lisp-byte-compile Regards, -- Nicolas Goaz

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-02 Thread Christian Garbs
Hi, On Wed, Aug 02, 2017 at 12:03:50AM +0200, Nicolas Goaziou wrote: > Christian Garbs writes: > > Some of your proposed changes apply to ob-C.el as well. I could > > prepare a different patch for that (under which topic?), > > Depending on the size of the changes, it could be "Tiny changes",

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-01 Thread Nicolas Goaziou
Hello, Christian Garbs writes: > Hello and sorry for the wait! No problem. > Looking at the other defcustoms, is the current wording ok? It is. > Some of your proposed changes apply to ob-C.el as well. I could > prepare a different patch for that (under which topic?), Depending on the size

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-08-01 Thread Christian Garbs
Hello and sorry for the wait! On Sun, Jul 23, 2017 at 11:05:02AM +0200, Nicolas Goaziou wrote: > Christian Garbs writes: > > > * ob-vala.el: Add support for the Vala language to Babel. > > +(defvar org-babel-vala-compiler "valac" > > + "Command used to compile a Vala source code file into an >

Re: [O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-07-23 Thread Nicolas Goaziou
Hello, Christian Garbs writes: > * ob-vala.el: Add support for the Vala language to Babel. Thank you. Comments follow. > +;; file extension ;; File extension. > +;; header arguments empty by default ;; Header argument empty by default. > +(defvar org-babel-vala-compiler "valac" > + "Comma

[O] [PATCH] ob-vala.el: Add Vala support to Babel

2017-07-14 Thread Christian Garbs
* ob-vala.el: Add support for the Vala language to Babel. --- lisp/ob-vala.el | 129 1 file changed, 129 insertions(+) create mode 100644 lisp/ob-vala.el diff --git a/lisp/ob-vala.el b/lisp/ob-vala.el new file mode 100644 index 000..9b