Re: [O] [PATCH] ob-python: Insert necessary blank line when sending code to interpreter

2018-04-03 Thread qijian gong
I've added comment and test (New path file in attachment),the test results look fine. #+BEGIN_SRC sh $ make BTEST_RE="test-ob-python" test-dirty ... selected tests: test-ob-python Running 7 tests (2018-04-03 16:51:31+0800) executing Python code block... Code block evaluation complete. passed 1

Re: [O] [PATCH] ob-python: Insert necessary blank line when sending code to interpreter

2018-04-02 Thread Nicolas Goaziou
Hello, qijian gong writes: > I've written this patch to fix the syntax error alarm caused by evaluating > the following code block: > > #+BEGIN_SRC python :session > if True: > 1 > 2 > #+END_SRC Thank you. Could you add a test in "test-ob-python.el"? Could you also add a comment explainin

[O] [PATCH] ob-python: Insert necessary blank line when sending code to interpreter

2018-04-01 Thread qijian gong
Hello, I've written this patch to fix the syntax error alarm caused by evaluating the following code block: #+BEGIN_SRC python :session if True: 1 2 #+END_SRC In *Python* buffer: #+BEGIN_QUOTE if True: Python 3.6.1 (default, Apr 8 2017, 19:21:02) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (cla

Re: [O] [PATCH] ob-python: Fix python session initialization

2015-10-29 Thread Aaron Ecay
Hi Grégoire, I’ve looked at ‘org-babel-python-initiate-session’ and I can’t see an obvious bug. Did you come up with a patch to fix the problems you were seeing? Thanks, -- Aaron Ecay

Re: [O] [PATCH] ob-python: Fix python session initialization

2015-10-01 Thread Grégoire Jadi
Grégoire Jadi writes: > Hi, > > There is a bug in ob-python, the parameters aren't used to initialize > the session. Here is a patch that fixes it. Err, discard this. It's not enough to fix the bug since `org-babel-python-initiate-session' doesn't use the params either. I'll come back later with

[O] [PATCH] ob-python: Fix python session initialization

2015-10-01 Thread Grégoire Jadi
Hi, There is a bug in ob-python, the parameters aren't used to initialize the session. Here is a patch that fixes it. OK to push ? * lisp/ob-python.el (org-babel-execute:python): Send params to `org-babel-python-initiate-session'. It was not possible to configure the sesssion with custom param

Re: [O] [PATCH] ob-python

2013-08-12 Thread Eric Schulte
Applied. Thanks, Achim Gratz writes: > From 8f3c510f43e458a1bbb58b126fc4e402007e6cfe Mon Sep 17 00:00:00 2001 > From: Achim Gratz > Date: Mon, 12 Aug 2013 21:10:27 +0200 > Subject: [PATCH] ob-python: run-python requires argument cmd > > * lisp/ob-python.el: Supply non-optional argument `cmd' t

[O] [PATCH] ob-python

2013-08-12 Thread Achim Gratz
>From 8f3c510f43e458a1bbb58b126fc4e402007e6cfe Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Mon, 12 Aug 2013 21:10:27 +0200 Subject: [PATCH] ob-python: run-python requires argument cmd * lisp/ob-python.el: Supply non-optional argument `cmd' to all invocations of `run-python'. Invert a cond

Re: [O] [PATCH] ob-python: specify defcustom parameters

2012-12-11 Thread Eric Schulte
Achim Gratz writes: > Eric Schulte writes: >> Again, could you send a git format-patch version of this patch? > > Sorry if this comes through twice, but it appears that Gmane has dropped > my first posting. > I only got this once. Thanks for re-sending, I'll apply this when next I push to the g

Re: [O] [PATCH] ob-python: specify defcustom parameters

2012-12-11 Thread Achim Gratz
Eric Schulte writes: > Again, could you send a git format-patch version of this patch? Sorry if this comes through twice, but it appears that Gmane has dropped my first posting. >From b759805cca39914843222c25a63854c7694d7e80 Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Fri, 7 Dec 2012 21:05:

Re: [O] [PATCH] ob-python: specify defcustom parameters

2012-12-11 Thread Eric Schulte
Achim Gratz writes: > This avoids a byte-compiler warning and makes these customizations > easier to find. > Again, could you send a git format-patch version of this patch? Then I will apply it. Thanks. -- Eric Schulte http://cs.unm.edu/~eschulte

[O] [PATCH] ob-python: specify defcustom parameters

2012-12-07 Thread Achim Gratz
This avoids a byte-compiler warning and makes these customizations easier to find. --8<---cut here---start->8--- commit 9666909a8db4f8ba54c6cabde40f35cbf82a3b52 (HEAD, refs/heads/lth-mk) Author: Achim Gratz Date: Fri Dec 7 21:05:52 2012 +0100 ob-python: