Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-05-02 Thread Nicolas Goaziou
Bill Wishon writes: > What I was trying to achieve when I got into trying out the > org-export-format-drawer-function was to try and customize the look of the > properties drawers when they're exported to html. By default they are > exported as pre formatted text with the class=example. What wo

Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-05-01 Thread Bill Wishon
On Tue, May 1, 2012 at 11:18 AM, Nicolas Goaziou wrote: > There are other, and more standard, ways to achieve the > same result in the new export engine (filters being one). > What I was trying to achieve when I got into trying out the org-export-format-drawer-function was to try and customize th

Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-05-01 Thread Nicolas Goaziou
Hello, Bastien writes: >> My thought was that you could have multiple hooks in >> org-export-format-drawer-function and each one could be checking for >> things like "is this html export", "is the drawer name == PROPERTIES" >> and could decide to take action and return a string, or perhaps take

Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-05-01 Thread Bill Wishon
On Tue, May 1, 2012 at 10:58 AM, Bastien wrote: > We would need to rename `org-export-format-drawer-function' to > suggest it can be a list of functions > Maybe this is a non-issue then. I had assumed it was a hook because it was on the page describing org-mode hooks, but your right that it doe

Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-05-01 Thread Bastien
Hi Bill, Bill Wishon writes: > My thought was that you could have multiple hooks in > org-export-format-drawer-function and each one could be checking for > things like "is this html export", "is the drawer name == PROPERTIES" > and could decide to take action and return a string, or perhaps tak

Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-05-01 Thread Bill Wishon
Hi Bastien, I'll try to find a different mail client next time. On Tue, May 1, 2012 at 3:01 AM, Bastien wrote: > I don't really understand why `run-hook-with-args-until-success' is > needed here. Or `org-export-format-drawer-function' returns a string, > or it returns nil, in case we fall back

Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-05-01 Thread Bastien
Hi Bill, Thanks for the patch. Please don't attach patches using application/octet-stream, patchwork don't catch those -- see http://orgmode.org/worg/org-contribute.html#sec-4-3 Bill Wishon writes: > * lisp/org-exp.el (org-export-remove-or-extract-drawers): Changed > funcall to run-hook-wi

[O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers

2012-04-30 Thread Bill Wishon
* lisp/org-exp.el (org-export-remove-or-extract-drawers): Changed funcall to run-hook-with-args-until-success to properly run the org-export-format-drawer-function hook. The problem was that funcall was being executed on the hook (list of functions) instead of running the hook with run-hook-with-a