Re: [O] [PATCH] Write org variables into own R environment

2014-03-26 Thread Rainer M Krug
Aaron Ecay writes: > Hi Rainer, > > This patch looks very promising. (I have not had a chance to test the > implementation yet). Thanks - please let me know as soon as you tested it. > One issue might be the name of the “org” variable > – maybe this should instead be “.org” or “_org” to less

Re: [O] [PATCH] Write org variables into own R environment

2014-03-25 Thread Aaron Ecay
Hi Rainer, This patch looks very promising. (I have not had a chance to test the implementation yet). One issue might be the name of the “org” variable – maybe this should instead be “.org” or “_org” to lessen the chance of stomping on pre-existing variables named “org” in people’s code. Thanks

Re: [O] [PATCH] Write org variables into own R environment instead of .GlobalEnv

2014-03-20 Thread Rainer M Krug
Bastien writes: > Rainer M Krug writes: > >> OK - I'll let you know when I hear something. > > We should both hear about it. > > Please ping me if you don't hear anything in a month, > I'll then ask again to the FSF copyright clerk. I'll do - thanks. > > Also, the formatting of the Changel

Re: [O] [PATCH] Write org variables into own R environment instead of .GlobalEnv

2014-03-20 Thread Bastien
Rainer M Krug writes: > OK - I'll let you know when I hear something. We should both hear about it. Please ping me if you don't hear anything in a month, I'll then ask again to the FSF copyright clerk. Also, the formatting of the Changelog entry is not correct, please carefully read

Re: [O] [PATCH] Write org variables into own R environment instead of .GlobalEnv

2014-03-20 Thread Rainer M Krug
Bastien writes: > Hi Rainer, > > Rainer M Krug writes: > >> I mailed them on Tuesday, using the form >> [[http://orgmode.org/request-assign-future.txt]] but did not get a >> response. > > This usually take 4-6 weeks, so let's be patient. OK - I'll let you know when I hear something. > >>> Also

[O] [PATCH] Write org variables into own R environment

2014-03-20 Thread Rainer M Krug
* lisp/ob-R.el (org-babel-expand-body:R): Create empty environment called `org' in R before adding variables and afterwards lock it and add it to the R search path. (org-babel-variable-assignments:R): Assign variables into own `org' environment in R instead of .GlobalEnv These patch imple

Re: [O] [PATCH] Write org variables into own R environment instead of .GlobalEnv

2014-03-20 Thread Bastien
Hi Rainer, Rainer M Krug writes: > I mailed them on Tuesday, using the form > [[http://orgmode.org/request-assign-future.txt]] but did not get a > response. This usually take 4-6 weeks, so let's be patient. >> Also, the formatting of the Changelog entry is not correct, >> please carefully read

Re: [O] [PATCH] Write org variables into own R environment instead of .GlobalEnv

2014-03-20 Thread Rainer M Krug
Bastien writes: > Hi Rainer, > > did you sign the FSF papers? We need this before considering applying > the patch. I mailed them on Tuesday, using the form [[http://orgmode.org/request-assign-future.txt]] but did not get a response. > Also, the formatting of the Changelog entry is not corre

Re: [O] [PATCH] Write org variables into own R environment instead of .GlobalEnv

2014-03-18 Thread Bastien
Hi Rainer, did you sign the FSF papers? We need this before considering applying the patch. Also, the formatting of the Changelog entry is not correct, please carefully read http://orgmode.org/worg/org-contribute.html Thanks, -- Bastien

[O] [PATCH] Write org variables into own R environment instead of .GlobalEnv

2014-03-18 Thread Rainer M Krug
* (org-babel-R-assign-elisp): replaced simple assignments of variables to variables in R with assignments into an environment called 'org' and lock these so that they can not be modified anymore. * (org-babel-expand-body:R): wrap the call of `org-babel-variable-assignments:R' into - detachmen