Re: [O] [PATCH] Update statistic cookies when archiving

2017-09-06 Thread Nicolas Goaziou
Hello, Jay Kamat writes: > Done. Applied. Thank you! > > I'm not sure if I did the tests 'correctly' though. I placed them in > test-org-element.el since there was a little bit of archive based > testing there, is there a better place to put them? I couldn't find any > file for org-archive test

Re: [O] [PATCH] Update statistic cookies when archiving

2017-09-03 Thread Jay Kamat
Hi, > Be warned that we're in a feature-freeze phase. It will have to wait for > Org 9.1 before being merged. Sounds good to me! > >> +;; Go to parent, even if no children exist > > Nitpick: Missing final dot. > >> +(org-up-heading-safe) >> +;; Update cookie of parent > >

Re: [O] [PATCH] Update statistic cookies when archiving

2017-09-03 Thread Nicolas Goaziou
Hello, Jay Kamat writes: > Sorry, forgot to actually attach the patch, here it is. > > From 95cdfa8c3ec81b3a0763b68044611c10a4dadc29 Mon Sep 17 00:00:00 2001 > From: Jay Kamat > Date: Sat, 2 Sep 2017 15:57:36 -0400 > Subject: [PATCH] org-archive.el: Update statistic cookies when > archiving Th

Re: [O] [PATCH] Update statistic cookies when archiving

2017-09-02 Thread Jay Kamat
Sorry, forgot to actually attach the patch, here it is. >From 95cdfa8c3ec81b3a0763b68044611c10a4dadc29 Mon Sep 17 00:00:00 2001 From: Jay Kamat Date: Sat, 2 Sep 2017 15:57:36 -0400 Subject: [PATCH] org-archive.el: Update statistic cookies when archiving * lisp/org-archive.el (org-archive-subtre

[O] [PATCH] Update statistic cookies when archiving

2017-09-02 Thread Jay Kamat
Hi, Currently, statistic cookies do not update when archiving headings. For example, when archiving the 'Two' header in the below example: * Top [50%] ** TODO One ** DONE Two The status cookie on 'Top' does not get set to [100%]. I have attached a draft patch to add support for this. However, I