Re: [O] [PATCH] Make lexical eval default for elisp src blocks

Hello, John Kitchin writes: > I think it would be fine to make :lexical "no" be the default, since > that should preserve what we are used to. Users can alway set a > different default of their own, or make it "yes" when they know it is > needed. Fair enough. Done. Thank you. Regards, -- Nic

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

I think it would be fine to make :lexical "no" be the default, since that should preserve what we are used to. Users can alway set a different default of their own, or make it "yes" when they know it is needed. Nicolas Goaziou writes: > Hello, > > John Kitchin writes: > >> Set default in `org-ba

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

Hello, John Kitchin writes: > Set default in `org-babel-default-header-args:emacs-lisp'. Add an > optional argument to the eval function. Applied. Thank you. However, it seems that some tests are now failing. I guess this is related to Babel calls, which are eval'ed as emacs-lisp source blocks

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

thanks. I think I have addressed these in a new patch I just submitted. John --- Professor John Kitchin Doherty Hall A207F Department of Chemical Engineering Carnegie Mellon University Pittsburgh, PA 15213 412-268-7803 @johnkitchin http://kitchingroup.cheme.cmu.edu

[O] [PATCH] Make lexical eval default for elisp src blocks

Set default in `org-babel-default-header-args:emacs-lisp'. Add an optional argument to the eval function. --- etc/ORG-NEWS | 11 +++ lisp/ob-emacs-lisp.el | 33 - 2 files changed, 35 insertions(+), 9 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

John Kitchin writes: > I just put it in because it is an option for the eval function, and it was > not difficult to implement. It might be useful for debugging. Fair enough. > Are you suggesting use defconst instead of defvar? Does it really need all > the things in org-babel-header-args:R? Or

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

Thanks for the feedback. I have a few questions below. On Mon, Apr 18, 2016 at 12:38 PM, Nicolas Goaziou wrote: > Hello, > > John Kitchin writes: > > > Set default in `org-babel-default-header-args:emacs-lisp'. Add an > > optional argument to the eval function. > > Thanks for the patch. Some c

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

Hello, John Kitchin writes: > Set default in `org-babel-default-header-args:emacs-lisp'. Add an > optional argument to the eval function. Thanks for the patch. Some comments follow. > +*** Default lexical evaluation of emacs-lisp src blocks > +Emacs-lisp src blocks in babel are now evaluated u

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

I don't think so. I haven't seen this be the case. A simple example like this works as expected I think. #+BEGIN_SRC emacs-lisp (setq x 4) #+END_SRC #+RESULTS: : 4 #+BEGIN_SRC emacs-lisp (+ x 9) #+END_SRC #+RESULTS: : 13 So far, I have only seen where this makes some new things possible. e.g

Re: [O] [PATCH] Make lexical eval default for elisp src blocks

John Kitchin writes: Forgive my ignorance--I haven't really dug into lexical scoping yet--but what is the basic effect will this change have on elisp code blocks? Say I'm doing some sort-of literate development and I have some code blocks that `setq' here and there, setting vars in the Emacs envi

[O] [PATCH] Make lexical eval default for elisp src blocks

Set default in `org-babel-default-header-args:emacs-lisp'. Add an optional argument to the eval function. --- etc/ORG-NEWS | 11 +++ lisp/ob-emacs-lisp.el | 29 - 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG-NEW