Re: [O] [PATCH] Improve message when file to include is missing

"Sebastien Vauban" writes: > I don't have (yet) push access... OK. Applied, with a small refactoring. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Improve message when file to include is missing

Hello Nicolas, Nicolas Goaziou wrote: > "Sebastien Vauban" writes: > >> This should answer your (fruitful) comments. > > Thank you for the update. > > It looks good. Thanks. > AFAIC, you can push it. I don't have (yet) push access... >> +(if (or (not file) (not (file-readable-p file))) >>

Re: [O] [PATCH] Improve message when file to include is missing

Hello, "Sebastien Vauban" writes: > This should answer your (fruitful) comments. Thank you for the update. It looks good. AFAIC, you can push it. > +(if (or (not file) (not (file-readable-p file))) > + (if (not noerror) > + (error "Cannot read file \"%s\"%s" file info-from-f

Re: [O] [PATCH] Improve message when file to include is missing

Hello Nicolas, Nicolas Goaziou wrote: > "Sebastien Vauban" writes: > >> When a SETUPFILE is missing, there is an error or message generated, but >> we don't know in which file the bad reference is -- when all those files >> are loaded during the agenda generation. >> >> Hence, a better message, sp

Re: [O] [PATCH] Improve message when file to include is missing

Nicolas Goaziou writes: > What if `buffer-file-name' returns nil? Sure, the problem won't happen > during agenda generation, but `org-file-contents' is used elsewhere. > > Also, it is better to use: > > (buffer-file-name (buffer-base-buffer)) > > since the current buffer may be an indirect on

Re: [O] [PATCH] Improve message when file to include is missing

"Sebastien Vauban" writes: > When a SETUPFILE is missing, there is an error or message generated, but > we don't know in which file the bad reference is -- when all those files > are loaded during the agenda generation. > > Hence, a better message, specifying where to go and look for the bad >

Re: [O] [PATCH] Improve message when file to include is missing

Hello, "Sebastien Vauban" writes: > When a SETUPFILE is missing, there is an error or message generated, but > we don't know in which file the bad reference is -- when all those files > are loaded during the agenda generation. > > Hence, a better message, specifying where to go and look for th

[O] [PATCH] Improve message when file to include is missing

Hello, When a SETUPFILE is missing, there is an error or message generated, but we don't know in which file the bad reference is -- when all those files are loaded during the agenda generation. Hence, a better message, specifying where to go and look for the bad link. Best regards, Seb >From