Re: [O] [PATCH] Fix renumbering for footnotes at BOL.

2011-09-29 Thread Nicolas Goaziou
Patch applied. Thank you. Now, onto the other problems in that function... Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Fix renumbering for footnotes at BOL.

2011-09-29 Thread Tassilo Horn
Nicolas Goaziou writes: Hi! >> I don't either, and that's a good thing. I added that just as some >> extra paranoia so that you get an error if a footnote gets broken. > > Well, provided the first part of the function doesn't modify the > buffer, I still don't see how the assert could fail, eve

Re: [O] [PATCH] Fix renumbering for footnotes at BOL.

2011-09-29 Thread Nicolas Goaziou
Tassilo Horn writes: > Nicolas Goaziou writes: >> About your patch, I have but one question: I don't get a situation in >> which the assert would be triggered, may you give me such an example? > I don't either, and that's a good thing. I added that just as some > extra paranoia so that you ge

Re: [O] [PATCH] Fix renumbering for footnotes at BOL.

2011-09-29 Thread Tassilo Horn
Nicolas Goaziou writes: > It looks like the original function isn't right in more than one way > (it doesn't even make sure the matched string is really a > footnote). But that's another topic. Yes, indeed. > About your patch, I have but one question: I don't get a situation in > which the asse

Re: [O] [PATCH] Fix renumbering for footnotes at BOL.

2011-09-29 Thread Nicolas Goaziou
Hello, Tassilo Horn writes: > org-footnote-renumber-fn:N invalidates footnotes that appear as the > first thing on a line. Here's a test file including the recipe. > > * Bla > > This is a line in which the following footnote that is inserted exactly > [fn:1] is the first thing in that line.

[O] [PATCH] Fix renumbering for footnotes at BOL.

2011-09-29 Thread Tassilo Horn
Hi all, org-footnote-renumber-fn:N invalidates footnotes that appear as the first thing on a line. Here's a test file including the recipe. --8<---cut here---start->8--- * Bla This is a line in which the following footnote that is inserted exactly [fn:1]