Re: [O] [PATCH] Fix error prone babel table output format detection

Hi Ian, Ian Kelling writes: > Done. I was actually following the instructions in man git-format-patch by > not attaching it before, but I will avoid that in future. Applied, thanks. I slightly rewrote the changelog message, please have a look for further patches. Thanks! -- Bastien

Re: [O] [PATCH] Fix error prone babel table output format detection

Eric Schulte writes: > This looks good to me. Could you reformat the patch with > > git format-patch > > and attach the results (this will be easier to apply). Done. I was actually following the instructions in man git-format-patch by not attaching it before, but I will avoid that in future.

Re: [O] [PATCH] Fix error prone babel table output format detection

This looks good to me. Could you reformat the patch with git format-patch and attach the results (this will be easier to apply). Also, this patch is small enough to apply without any sort of copyright attribution, but if you think you might make larger contributions in the future, please look

Re: [O] [PATCH] Fix error prone babel table output format detection

Eric Schulte writes: > Hi Ian, > > You should use the `org-every' function here. Look at the source of > that function to see code to efficiently perform this sort of check. > > Best, > Brilliant. Thank you. The updated patch below should be good. -- >8 -- Subject: [PATCH] Fix error prone babe

Re: [O] [PATCH] Fix error prone babel table output format detection

Ian Kelling writes: > Ian Kelling writes: >> It's a bit late. here is the same patch with correct indentation. > > That patch went out of it's way not to check more of the list than was > necessary, but after sending it, I kept thinking that it does extra > things which possibly negate any perf

Re: [O] [PATCH] Fix error prone babel table output format detection

Ian Kelling writes: > It's a bit late. here is the same patch with correct indentation. That patch went out of it's way not to check more of the list than was necessary, but after sending it, I kept thinking that it does extra things which possibly negate any performance benefit of not checking

Re: [O] [PATCH] Fix error prone babel table output format detection

Ian Kelling writes: > Below is a patch that addresses the 2 previously mentioned > problems. It's a bit late. here is the same patch with correct indentation. > -- >8 -- Subject: [PATCH] Fix error prone babel table output format detection * lisp/ob-core.el: Test that all elements are in a lis

Re: [O] [PATCH] Fix error prone babel table output format detection

Ian Kelling writes: > Achim Gratz writes: > >> Ian Kelling writes: >>> org-babel table output uses different formatting for a list of lists, >>> but detects it incorrectly causing an error, as in this example: >>> #+begin_src emacs-lisp >>> '((1) 2) >>> #+end_src >> >> So this isn't a proper ta

Re: [O] [PATCH] Fix error prone babel table output format detection

Achim Gratz writes: > Ian Kelling writes: >> org-babel table output uses different formatting for a list of lists, >> but detects it incorrectly causing an error, as in this example: >> #+begin_src emacs-lisp >> '((1) 2) >> #+end_src > > So this isn't a proper table, what do you expect to happen

Re: [O] [PATCH] Fix error prone babel table output format detection

Ian Kelling writes: > org-babel table output uses different formatting for a list of lists, > but detects it incorrectly causing an error, as in this example: > #+begin_src emacs-lisp > '((1) 2) > #+end_src So this isn't a proper table, what do you expect to happen? > -

[O] [PATCH] Fix error prone babel table output format detection

>From dc0b727328266785528fe160046ae1aa8df8a993 Mon Sep 17 00:00:00 2001 Message-ID: <87zjj2ous9@treetowl.lan> MIME-Version: 1.0 Content-Type: text/plain * lisp/ob-core.el: Test that all elements are in a list are lists instead of just the first. org-babel table output uses different formattin