Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-12-11 Thread Nicolas Goaziou
Hello, Doro Rose writes: > Nicolas Goaziou writes: > >> Fair enough. Could you provide a proper commit message and send the >> patch again? > > Here's the patch. Applied. Thank you. Regards, -- Nicolas Goaziou0x80A93738

Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-12-02 Thread Doro Rose
Nicolas Goaziou writes: > Fair enough. Could you provide a proper commit message and send the > patch again? Here's the patch. >From 646d457f8d3e5d38084f44adfacf38a8cc762c30 Mon Sep 17 00:00:00 2001 From: louis Date: Sat, 2 Dec 2017 21:21:39 +0100 Subject: [PATCH] ob-haskell.el: Fix ob-haskell

Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-11-29 Thread Nicolas Goaziou
Hello, Doro Rose writes: > Nicolas Goaziou writes: > >> Hello, >> >> Doro Rose writes: >> >>> In summary, yes I'm accessing user settings but in a rather >>> noninvasive way. Unfortunately I can't think of a more elegant way to >>> do this. >> >> Let's put it differently then. Isn't it the job

Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-11-18 Thread Doro Rose
Nicolas Goaziou writes: > Hello, > > Doro Rose writes: > >> In summary, yes I'm accessing user settings but in a rather >> noninvasive way. Unfortunately I can't think of a more elegant way to >> do this. > > Let's put it differently then. Isn't it the job of the user, who changed > their prompt

Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-11-17 Thread Nicolas Goaziou
Hello, Doro Rose writes: > In summary, yes I'm accessing user settings but in a rather > noninvasive way. Unfortunately I can't think of a more elegant way to > do this. Let's put it differently then. Isn't it the job of the user, who changed their prompt, to configure properly "inf-haskell" li

Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-11-16 Thread Doro Rose
Nicolas Goaziou writes: > Doesn't this kind of configuration ultimately belongs to the user? Org > is not supposed to mess with `haskell-prompt-regexp' in the current > buffer, IMO."Doesn't this kind of configuration ultimately belongs to the > user? Org I figured, since I'm only adding another

Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-11-16 Thread Nicolas Goaziou
Hello, Doro Rose writes: > I noticed that ob-haskell.el doesn't support custom ghci prompts at present. > Custom ghci prompts such as "λ>" are quite popular in the haskell community, > see for example > > https://stackoverflow.com/questions/42081379/how-to-set-up-org-babel-for-haskell-with-stac

[O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts

2017-11-07 Thread Doro Rose
Hi, I noticed that ob-haskell.el doesn't support custom ghci prompts at present. Custom ghci prompts such as "λ>" are quite popular in the haskell community, see for example https://stackoverflow.com/questions/42081379/how-to-set-up-org-babel-for-haskell-with-stack Could you have a look at the