Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-10-04 Thread Leo Butler
On Wed, Oct 04 2023, Ihor Radchenko wrote: > Leo Butler writes: > >> Attached is: >> >> - my previous patch, rebased against the latest HEAD and only modified >> to include a patch to etc/ORG-NEWS >> - a patch to the worg docs that corrects the urls >> - a patch to the worg docs that documents

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-10-04 Thread Ihor Radchenko
Leo Butler writes: > Attached is: > > - my previous patch, rebased against the latest HEAD and only modified > to include a patch to etc/ORG-NEWS > - a patch to the worg docs that corrects the urls > - a patch to the worg docs that documents the new header arguments and > provides examples of

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-10-02 Thread Leo Butler
On Fri, Sep 22 2023, Ihor Radchenko wrote: > Leo Butler writes: > >>> What is the purpose of this `unwind-protect'? >>> In its current form, it does nothing because no UNWINDFORMS are >>> provided. >> >> I copied the forms from tests I had written for ob-octave, without >> thinking about why tho

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-22 Thread Ihor Radchenko
Leo Butler writes: >> What is the purpose of this `unwind-protect'? >> In its current form, it does nothing because no UNWINDFORMS are >> provided. > > I copied the forms from tests I had written for ob-octave, without > thinking about why those tests were wrapped in an `unwind-protect' > form. T

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-21 Thread Leo Butler
On Thu, Sep 21 2023, Ihor Radchenko wrote: > Leo Butler writes: > +(defconst org-babel-header-args:maxima + '((batch . :any) >>> >>> Why :any? Only two values are allowed here. >>> +(graphics-pkg. :any)) >>> >>> Same. The value is a closed list. >> >> I

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-21 Thread Ihor Radchenko
Leo Butler writes: >>> +(defconst org-babel-header-args:maxima >>> + '((batch . :any) >> >> Why :any? Only two values are allowed here. >> >>> +(graphics-pkg. :any)) >> >> Same. The value is a closed list. > > I have made the change requested. > > However, beyond the do

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-20 Thread Leo Butler
On Wed, Sep 20 2023, Ihor Radchenko wrote: > Leo Butler writes: > > May you clarify the purpose of "linenum"? >>> Do I understand correctly that the above will simply affect debug output >>> when maxima references where a problematic line is located in the source? >> >> No, it affects how ou

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-20 Thread Ihor Radchenko
Leo Butler writes: May you clarify the purpose of "linenum"? >> Do I understand correctly that the above will simply affect debug output >> when maxima references where a problematic line is located in the source? > > No, it affects how output labels are printed. With this value, the > "firs

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-19 Thread Leo Butler
On Sat, Sep 16 2023, Ihor Radchenko wrote: > Leo Butler writes: > >>> Also, non-standard arguments should be defined in >>> `org-babel-header-args:maxima'. >>> >> >> Ok. I see that some packages (e.g. ob-gnuplot.el) use a `defvar' form, >> while others (e.g. ob-R.el) use a `defconst' form. Is t

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-16 Thread Ihor Radchenko
Leo Butler writes: >> Also, non-standard arguments should be defined in >> `org-babel-header-args:maxima'. >> > > Ok. I see that some packages (e.g. ob-gnuplot.el) use a `defvar' form, > while others (e.g. ob-R.el) use a `defconst' form. Is there a preference? defconst I think. The value is not

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-15 Thread Leo Butler
On Fri, Sep 15 2023, Ihor Radchenko wrote: > Leo Butler writes: > >> Attached is a patch that tries to address some of Ihor's concerns. I >> have added two header arguments for maxima src blocks: > > Thanks! > >> - :graphics-pkg lets the user choose the graphics package to use; >> >> - :batch le

Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-15 Thread Ihor Radchenko
Leo Butler writes: > Attached is a patch that tries to address some of Ihor's concerns. I > have added two header arguments for maxima src blocks: Thanks! > - :graphics-pkg lets the user choose the graphics package to use; > > - :batch lets the user choose which source-code loader Maxima will u

[PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

2023-09-12 Thread Leo Butler
On Thu, Sep 07 2023, Ihor Radchenko wrote: > `org-babel-execute:maxima' relies on certain output that maxima > produces. Removing --very-quiet will make the assumptions in the code no > longer valid. Worse - it might happen that in the absence of --very-quiet > `org-babel-execute:maxima' (or its

Re: [MAINTENANCE] On how much we can expose internals into defcustom

2023-09-07 Thread Ihor Radchenko
Leo Butler writes: >> ... >> In order to make such a switch, we will have to force all the users >> change their customization - something we do not want to annoy users >> with. > > I understand your general argument, but I doubt it is relevant to this > particular case. > > In this specific case

Re: [MAINTENANCE] On how much we can expose internals into defcustom

2023-09-06 Thread Leo Butler
On Tue, Sep 05 2023, Ihor Radchenko wrote: > CCing Bastien, as he might want to intervene. > > Leo Butler writes: > >>> +(defcustom org-babel-maxima-command-arguments >>> + "--very-quiet" >> >>> +(defcustom org-babel-maxima-batch/load >>> + "batchload" >>> + >>> +(d

[MAINTENANCE] On how much we can expose internals into defcustom (was: [BUG] Consider replacing bachload with batch in ob-maxima. [9.6.6 (release_9.6.6 @ /usr/share/emacs/30.0.50/lisp/org/)])

2023-09-05 Thread Ihor Radchenko
CCing Bastien, as he might want to intervene. Leo Butler writes: >> +(defcustom org-babel-maxima-command-arguments >> + "--very-quiet" > >> +(defcustom org-babel-maxima-batch/load >> + "batchload" >> + >> +(defcustom org-babel-maxima-graphic-file-format-string >> + "(s