Sławomir Grochowski writes:
> Subject: [PATCH] lisp/org-colview.el: org-columns-compile-format regexp bugfix
Thanks!
Applied, onto main.
Fixed.
I reworded the commit message a bit, making it slightly shorter and
making sure that there is double space between sentences. I also added a
small comm
Ihor Radchenko writes:
> There is no patch attached.
>From 987f66774db4ad1e515cac4b9fc5ba46bd627c27 Mon Sep 17 00:00:00 2001
From: Slawomir Grochowski
Date: Sat, 24 Aug 2024 18:47:09 +0200
Subject: [PATCH] lisp/org-colview.el: org-columns-compile-format regexp bugfix
MIME-Version: 1.0
Content-Ty
Sławomir Grochowski writes:
> Patch below:
> <#part type="text/x-diff"
> filename="~/.emacs.d/straight/repos/org/0001-lisp-org-colview.el-org-columns-compile-format-regex.patch"
> disposition=inline>
> <#/part>
There is no patch attached.
--
Ihor Radchenko // yantar92,
Org mode contributor,
I tried to describe the problem better as well as my thought process:
The `org-columns-compile-format' function has a bug in regexp.
When an empty parentheses `()` is in the 'column format string' -
and it always is when user do not provide a column title - then the
regexp can't capture the operat
Ihor Radchenko writes:
> May you also fix the regexp in `org-columns-compile-format'?
> I recommend using `rx' to make the regexp more readable and less prone
> to mistakes.
OK. I will try. String-based Emacs regexp is unreadable and quite scary
for me. That's why I always convert all regexes t
Sławomir Grochowski writes:
> I have found a bug in regexp.
> Test that need to pass to fix it is below.
Thanks!
May you also fix the regexp in `org-columns-compile-format'?
I recommend using `rx' to make the regexp more readable and less prone
to mistakes.
--
Ihor Radchenko // yantar92,
Org m
Hello,
I have found a bug in regexp.
Test that need to pass to fix it is below.
>From 9710f6befb1bd4eee2d508d7baaee95e825a68dc Mon Sep 17 00:00:00 2001
From: Slawomir Grochowski
Date: Mon, 19 Aug 2024 12:30:49 +0200
Subject: [PATCH] testing/lisp/test-org-colview.el: add test to pass to fix a
bu
