Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-17 Thread Bastien
Hi Andrew, Andrew Hyatt writes: > Thanks Bastien!  I've tested this out and confirmed it works, and > didn't notice any side effects.  Great, thanks for testing and confirming! -- Bastien

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-17 Thread Andrew Hyatt
Thanks Bastien! I've tested this out and confirmed it works, and didn't notice any side effects. On Fri, Feb 14, 2020 at 6:02 AM Bastien wrote: > Hi Andrew, > > thanks a lot for the minimal recipe! Very helpful. > I confirm the bug and I have now (finally) fixed it. > > We can close this bug f

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-14 Thread Bastien
Hi Andrew, thanks a lot for the minimal recipe! Very helpful. I confirm the bug and I have now (finally) fixed it. We can close this bug from... 2013 :) Best, -- Bastien

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-13 Thread Andrew Hyatt
I whittled this down to the smallest reproducible case, which I'm attaching. Hopefully should be clear upon viewing the file how to reproduce. I'm still unsure of the best solution, I'll have to think about this some more - but at least the reproducible case will make it easier to debug into this

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-10 Thread Bastien
Hi Matthew, not sure I replied to this one but in case I didn't, yes, my initial fix was wrong, I reverted it. Thanks! -- Bastien

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-05 Thread Matthew Lundin
Hi Bastien, Bastien writes: > > Andrew Hyatt writes: > >> Removing the (beginning-of-line 1) at the end of the time display >> code in that function, and substituting (org-agenda-previous-line) >> seems to fix it.  I'm not sure if that's the right approach - the >> previous code didn't use that

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-05 Thread Andrew Hyatt
It is fixed, but now the new time that's supposed to be displayed via text-properties does not show up. Let me spend some time and get a small reproducible case, which will help us test this. On Tue, Feb 4, 2020 at 6:38 PM Bastien wrote: > Hi Andrew, > > thanks again. > > Andrew Hyatt writes:

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-04 Thread Bastien
Hi Andrew, thanks again. Andrew Hyatt writes: > Removing the (beginning-of-line 1) at the end of the time display > code in that function, and substituting (org-agenda-previous-line) > seems to fix it.  I'm not sure if that's the right approach - the > previous code didn't use that function for

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-04 Thread Andrew Hyatt
I've tried the latest version from Feb 2nd, and it still has the same issue. After some more time with the issue, the issue is when the agenda has items A, and next line, invisibily (due to org-agenda-dim-blocked-tasks), B. Trying to set A gets you into an invisible loop because moving to the star

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-03 Thread Bastien
Hi Andrew, I have pushed some fixes in this area, if you have a chance to test Org from the latest maint or master branch, please do so and report if the problem persists. Thanks, -- Bastien

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-02 Thread Andrew Hyatt
On Sat, Feb 1, 2020 at 4:33 AM Bastien wrote: > Hi Andrew, > > Andrew Hyatt writes: > > > I've been having this same issue - the issue is quite reproducible > > for me, and it has been for years. I just finally grew tired of the > > issue and decided to investigate it, and yes, the issue is > >

Re: [BUG] Infinite loop in org-agenda-show-new-time

2020-02-01 Thread Bastien
Hi Andrew, Andrew Hyatt writes: > I've been having this same issue - the issue is quite reproducible > for me, and it has been for years.  I just finally grew tired of the > issue and decided to investigate it, and yes, the issue is > org-agenda-show-new-time. > > I also have invisible entries i

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2019-12-26 Thread Andrew Hyatt
I've been having this same issue - the issue is quite reproducible for me, and it has been for years. I just finally grew tired of the issue and decided to investigate it, and yes, the issue is org-agenda-show-new-time. I also have invisible entries in the org buffer, and the call to org-move-to-

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-23 Thread Nick Dokos
Carsten Dominik writes: > I also do not expect negative consequences. Please apply the patch, will you? > OK - patch attached. NB: there is at least one place where the "wrap the call to org-move-to-column" has been applied, in org.el:`org-comment-or-uncomment-region', presumably for exactly th

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-23 Thread Carsten Dominik
On 14.8.2013, at 17:45, Nick Dokos wrote: > Matt Lundin writes: > >> Nick Dokos writes: >> >>> >>> I haven't been able to work on the problem, but assuming that your >>> diagnosis above is correct, perhaps the thing to do is to bind >>> buffeer-invisibility-spec to nil inside org-move-to-co

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-14 Thread Nick Dokos
Matt Lundin writes: > Nick Dokos writes: > >> >> I haven't been able to work on the problem, but assuming that your >> diagnosis above is correct, perhaps the thing to do is to bind >> buffeer-invisibility-spec to nil inside org-move-to-column: >> >> (defun org-move-to-column (column &optional f

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-14 Thread Nick Dokos
Matt Lundin writes: > Nick Dokos writes: > >> Oh, oh: I just tried following the steps in your last email and I *did* >> get the infinite loop, with the same backtrace that you did. Then I >> tried it again just now and it did not happen again. Is this thing not >> 100% reproducible? > > FWIW, i

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-14 Thread Matt Lundin
Nick Dokos writes: > Oh, oh: I just tried following the steps in your last email and I *did* > get the infinite loop, with the same backtrace that you did. Then I > tried it again just now and it did not happen again. Is this thing not > 100% reproducible? FWIW, it is 100% reproducible here when

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-14 Thread Matt Lundin
Nick Dokos writes: > Matt Lundin writes: > >> ... >> In other words, within the agenda buffer, move-to-column and >> move-end-of-line will move to the point to the end of the entire >> invisible region. That is why removing the local binding of >> buffer-invisibility-spec to nil triggers this bu

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-10 Thread Nick Dokos
Matt Lundin writes: > ... > In other words, within the agenda buffer, move-to-column and > move-end-of-line will move to the point to the end of the entire > invisible region. That is why removing the local binding of > buffer-invisibility-spec to nil triggers this bug, because when that > variab

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-06 Thread Nick Dokos
Oh, oh: I just tried following the steps in your last email and I *did* get the infinite loop, with the same backtrace that you did. Then I tried it again just now and it did not happen again. Is this thing not 100% reproducible? In any case, I'm working through the rest of your email. I should ha

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-06 Thread Matt Lundin
Nick Dokos writes: > So you revert that commit and the infloop goes away? I looked at the > functions briefly and I don't understand how this commit could affect > what move-to-column does. Just to confirm: Did you try rescheduling with the agenda buffer filtered only to the home tag using the s

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-05 Thread Nick Dokos
Matt Lundin writes: > Nick Dokos writes: > >> Matt Lundin writes: >> >> My one feeble attempt to reproduce this failed. Looking at the code > > Here are the steps to reproduce the problem: > Thanks for the recipe: I still can't reproduce it - it just works for me. Org-mode version 8.0.7 (rele

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-05 Thread Matt Lundin
Nick Dokos writes: > Matt Lundin writes: > > My one feeble attempt to reproduce this failed. Looking at the code Here are the steps to reproduce the problem: 1. Create file test.org with the following content: --8<---cut here---start->8--- * TODO A

Re: [O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-05 Thread Nick Dokos
Matt Lundin writes: > When the agenda buffer is filtered by tag, I find that rescheduling an > item (via org-agenda-do-date-later, org-agenda-schedule, etc.) often > results in an infinite loop. > > I believe this loop occurs in the function org-agenda-show-new-time. > > Here are the steps I took

[O] [BUG] Infinite loop in org-agenda-show-new-time

2013-08-05 Thread Matt Lundin
When the agenda buffer is filtered by tag, I find that rescheduling an item (via org-agenda-do-date-later, org-agenda-schedule, etc.) often results in an infinite loop. I believe this loop occurs in the function org-agenda-show-new-time. Here are the steps I took to debug this: 1. I add a counte