Ihor Radchenko writes:
> Applied, onto bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=50b33e2d55
Thanks!
>>> -["Complete Lisp Symbol" lisp-complete-symbol t]
>>> +["Complete Lisp Symbol" completion-at-point t]
>>
>> (The final `t' there is redundant and can be
Ihor Radchenko writes:
> Stefan Kangas writes:
>
>> Org mode is still using the obsolete function `lisp-complete-symbol`,
>> but that function has been obsoleted in favor of `completion-at-point`
>> in version 24.4. The attached diff is not meant to be installed,
Glenn Morris writes:
> Package: emacs,org-mode
> Version: 28.0.50
> Severity: important
> Tags: security
>
> emacs -Q hello.org, where hello.org contains:
>
> #+macro: hello (eval (shell-command-to-string "touch /tmp/HELLO"))
> Hello. {{{hello}}}
>
> Then:
> M-x org-export-dispatch
> t A
>
> -> n
Org mode is still using the obsolete function `lisp-complete-symbol`,
but that function has been obsoleted in favor of `completion-at-point`
in version 24.4. The attached diff is not meant to be installed, but to
show where the problem is.
The usual schedule for removing obsolete functions in Ema
Ihor Radchenko writes:
> Ihor Radchenko writes:
>
>> Feel free to either install the change on Emacs side or provide a patch
>> for me to install on Org side.
>
> I converged your diff to a patch and installed it onto main branch.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id
Org uses the obsolete variable `filter-buffer-substring-functions'.
This variable is likely due for deletion in Emacs 31.1.
Usually, compatibility code looks for the new way of doing things, and
then prefers that. But it seems like someone decided here to look for
the old symbol instead, and pref
Ihor Radchenko writes:
> Stefan Kangas writes:
>
>> There is a reference to `header-arguments-alist', but I can't find any
>> such variable in the tree.
>>
>> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
>
> It is
There is a reference to `header-arguments-alist', but I can't find any
such variable in the tree.
./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
I think using HTTPS makes more sense for anonymous git access, for the
usual security and privacy reasons.
Please see the attached worg patch.
From f33276dd5ed54a6beb8b31aefb544f6fa3da4c08 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Mon, 10 Jun 2024 00:04:04 +0200
Subject: [PATCH] Prefer
Ihor Radchenko writes:
> Ihor Radchenko writes:
>
>> Confirmed.
>>
>> At this point, I feel that supporting isearch + text properties is an
>> uphill battle. I was hoping to contribute isearch.el patch upstream, but
>> apparently numerous other libraries (ispell, regexp-search, evil,
>> swiper)
Adam Porter writes:
> Since transient.el is part of Emacs now, these kinds of menus should
> probably be implemented with it.
IIUC, this is not a menu, but a reminder of key bindings that are usable
in that context. Other keybindings here are self-inserting keys, which
are equally useful, and t
Max Nikulin writes:
> On 01/02/2024 03:00, Stefan Kangas wrote:
>> Max Nikulin writes:
>>> +++ b/lisp/net/mailcap.el
>>> @@ -989,7 +989,8 @@ (defvar mailcap-mime-extensions
>>> (".jpe" . "image/jpeg")
>>> (".jpeg
Max Nikulin writes:
> From 8b71393625f11590e99896808bbd04ed83f7917e Mon Sep 17 00:00:00 2001
> From: Max Nikulin
> Date: Wed, 24 Jan 2024 21:16:28 +0700
> Subject: [PATCH] Use text/org media type
>
> Avoid "x-" prefix deprecated by rfc6648 for Org mode media type.
> * lisp/net/mailcap.el (mailca
Ihor Radchenko writes:
> I see using text/org as an improvement. text/x-org is likely useless.
> At least,
> https://github.com/jeremy-compostella/org-msg/blob/master/org-msg.el
> uses text/org, which may appear in email parts.
>
> However, AFAIU, text/org will fall into "standards tree" in IANA
Max Nikulin writes:
> Hi,
>
> I suggest to make the media type used for Org mode files consistent with
> the one used by XDG https://gitlab.freedesktop.org/xdg/shared-mime-info
> Currently Emacs has text/x-org, however "x-" prefix is not recommended
> by IANA any more, see https://www.rfc-editor.
Ihor Radchenko writes:
> Stefan Kangas writes:
>
>> The variable `org-publish-sitemap-file-entry-format' is documented in
>> org.org in emacs.git, but that variable is obsolete. Perhaps it should
>> be removed and/or updated.
>
> My grepping through Emacs so
The variable `org-publish-sitemap-file-entry-format' is documented in
org.org in emacs.git, but that variable is obsolete. Perhaps it should
be removed and/or updated.
Ihor Radchenko writes:
> With org-protocol, one can also make Emacs receive data from browser and
> perform any action defined by custom handler function - all fully
> configurable and not necessarily related to Org mode.
I don't have much to add besides giving support to the idea. It would
be
Ihor Radchenko writes:
> The refactoring de-coupled what used to be org-remember.el into
> completely rewritten org-capture.el that added important features that
> could not be implemented within remember.el framework:
>
> 1. org-capture arranges writing the text to remember directly into the
>
The attached patch improves the Swedish localization of
org-export-dictionary, and adds several missing entries.
From 12277e509118591d7ad7617494f6db45920b4f4b Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sat, 3 Dec 2022 12:31:13 +0100
Subject: [PATCH] Improve Swedish entry in org-export
The attached patch fixes two typos.
From bb00d528679174337dd9c7b26ee1514a21ce Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sat, 3 Dec 2022 11:43:51 +0100
Subject: [PATCH] ; Fix two typos
---
testing/lisp/test-org-datetree.el | 2 +-
testing/lisp/test-org.el | 2 +-
2 files
Just a small cleanup in preparation of 9.6, see attached.
From bb02572eb41f61023dc421f80709fa602a9a7822 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Mon, 21 Nov 2022 12:01:29 +0100
Subject: [PATCH] Remove 'org-speed-commands-user' warning
* lisp/org-keys.el (org-speed-command-hel
For posterity, this was closed by feature/noverlay being merged:
https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg02166.html
Ihor Radchenko writes:
>> Note that with the suggested feature, any link you follow risks being
>> loaded in Org mode, before the user even has a chance to inspect the
>> file. Which Org features, currently existing or introduced in the
>> future, would EWW have to add workarounds for?
>
> That'
Ihor Radchenko writes:
> The "problem" with shell links you are describing is a question of
> setting variables and is also disabled by default.
>
> eww-mode, when loading Org page, could simply set
> org-link-shell-confirm-function to its default value.
Note that with the suggested feature, any
00:00:00 2001
From: Stefan Kangas
Date: Sun, 2 Oct 2022 21:54:20 +0200
Subject: [PATCH 1/3] Add crossreference to org-stuck-projects docstring
* lisp/org-agenda.el (org-stuck-projects): Add Info manual reference
to docstring.
---
lisp/org-agenda.el | 9 +++--
1 file changed, 7 insertions(+)
Please find attached three separate documentation patches.
From 269faa44ec18bb63c61ecba4cb232ceb0e46cd10 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sun, 2 Oct 2022 21:54:20 +0200
Subject: [PATCH 1/3] Add crossreference to org-stuck-projects docstring
* lisp/org-agenda.el (org-stuck
Ihor Radchenko writes:
>>> I think this should be considered a bug, since the glyph used (LEFTWARDS
>>> TRIANGLE-HEADED ARROW / #2b60) is not present in most fonts.
If that is true (I don't know) then maybe we should just use a more
ubiquitous glyph?
> The commit is supposed to fall back to ASC
The attached patch fixes a small typo I found in the
`org-refile-targets' docstring.
From fe1c6f69ffcd3dfdb04c728f92e63e2fb1e4b4c0 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Wed, 13 Jul 2022 00:22:20 +0200
Subject: [PATCH] ; * lisp/org-refile.el (org-refile-targets): Fix typo.
---
Please see the attached.
From 5ecf4e9613993a520844b78880bf57c04f193880 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Thu, 30 Jun 2022 17:33:03 +0200
Subject: [PATCH] ; Fix typos
---
lisp/org-element.el | 14 +++---
lisp/org-fold-core.el| 10 +-
lisp
tch.
From aa0637c22ff1465a19d4007f1e9d16cc0df9972c Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Thu, 30 Jun 2022 13:06:21 +0200
Subject: [PATCH] Delete some Emacs 24 compat code
Org mode supports Emacs 26 or newer:
https://orgmode.org/worg/org-maintenance.html#emacs-compatibility
* lisp/org-compat.el (org-set-transient-
The attached patch deletes some Emacs 24 compat code. Org mode
supports Emacs 26 or later, according to:
https://orgmode.org/worg/org-maintenance.html#emacs-compatibility
From 6e854576494f918c36cdd0ce698793574af494df Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Thu, 30 Jun 2022 13:06:21
Ihor Radchenko writes:
> Applied onto main via a722f6f8e with amendment to the commit message.
It seems like i bungled the patch: two typos are fixed in the attached. Thanks.
From 29be11122821b18ffb56e109b4a9c457c65d1142 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Wed, 29 Jun 2022
Ihor Radchenko writes:
> Sure. Just trying to clarify my confusion. The inconsistency with some
> defcustoms using :version and some not is bugging me.
Agreed. It would be better to be consistent with this.
Kyle Meyer writes:
> In my view it'd be better to drop the first item. Org has removed
> plenty of obsolete features in its time, but searching the emacs.git
> history, I can't find a case where an Org-related file has been in
> lisp/obsolete/. I'd vote against setting that precedent, as I don'
Ihor Radchenko writes:
> >:group 'org-agenda
> > + :version "29.1"
> > ...
> > - :version "24.1"
> > + :version "29.1"
> >:type 'string)
>
> I am wondering if this is meaningful considering that Org is not always
> distributed together with Emacs. Will this :version tag make any sense
Ihor Radchenko writes:
> > 2. Delete the file from org-mode.git
> > ...
> > What do you think?
>
> Sounds good to me.
Patch attached.
From d609398f5a42a0157c309ead3e38be8ea78456f8 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Wed, 29 Jun 2022 05:36:47 +0200
Sub
org-install.el has been obsolete for more than 10 years.
To finally get rid of this file, I put it to you that all we need to do is:
1. Move it in emacs.git from lisp/org/org-install.el to
lisp/obsolete/org-install.el
2. Delete the file from org-mode.git
This means that all users (of old and new
The attached patch improves the look of the agenda time grid and
separator line on graphical displays. It was inspired by
org-modern.el by Daniel Mendler.
From dba6d68019c74232f581a55ab012fd9d06f53434 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Mon, 27 Jun 2022 14:04:00 +0200
Subject
Stefan Kangas writes:
> > > These options can be applied to selected agenda views. For more
> > > details about generation of agenda views, see the docstrings for the
> > > relevant variables, and this
> > > [[https://orgmode.org/worg/agenda-optimizat
Ihor Radchenko writes:
> Does it have to be inside the main chapters of the manual?
> I really hope that users do not _normally_ have to know about these
> tricks.
I've never needed it, FWIW.
However, it also feels misplaced among the appendixes. I guess this
is subjective: I prefer chapters t
Please see the attached patches. Thanks.
From 061255f1d6441f1496a3b062d6f29193ff2fb3c2 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sun, 26 Jun 2022 12:48:06 +0200
Subject: [PATCH 1/2] Move appendix on performance in manual to agenda chapter
* doc/org-manual.org (Speeding Up Your Agendas
It seems like the `org-agenda-custom-commands' docstring had some
missing and incorrect information. Please see the attached patch that
should improve the situation slightly.
From 72dd496e5eba7310854caa6c6daaee2cebd62662 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sun, 26 Jun 2022
ecommendations).
Please see the attached.
From cdd375813263250fd39be9888b3d0a68d9ba0063 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sun, 26 Sep 2021 09:44:29 +0200
Subject: [PATCH] Prefer "website" to "homepage"
Emacs now advises using "website" (instead of "
this.
From 68d4a3760535666fc69534a6f79ec3501626695f Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Fri, 24 Jun 2022 19:16:30 +0200
Subject: [PATCH] Avoid treating a number as an enum in manual
* doc/org-manual.org (The Agenda Dispatcher): Avoid treating
number as enum.
---
doc/org-manual.org | 4 ++--
1 file changed, 2 insert
I found the docstrings of the agenda date navigation commands to be
somewhat lacking. The attached patch expands them slightly and adds
crossreferences, which I think makes them much more usable. Thanks.
0001-Improve-docstrings-of-agenda-date-navigation-command.patch
Description: Binary data
Ihor Radchenko writes:
> > ... Emacs was recently
> > updated to list the "URL" header comment before "Homepage".
>
> Could you please point out to the relevant discussion?
This was uncontroversial so not really discussed, but see:
https://git.savannah.gnu.org/gitweb/?p=emacs.git;a=commit;h=bcf
er comment before "Homepage".
Please see the attached patch.
From 56ffe1256c4bdcc48d465c536c5bedcdb94d341e Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sun, 26 Sep 2021 09:44:29 +0200
Subject: [PATCH] Prefer "website" to "homepage"
These days, a "ho
Ihor Radchenko writes:
> Stefan Kangas writes:
>
> > The attached patch removes some compat code for XEmacs, and Emacs 21/22.
>
> Thanks! And sorry for the late reply.
> The patch does not apply onto current main anymore.
> Would you mind updating the patch?
Pleas
The attached patch removes some compat code for XEmacs, and Emacs 21/22.
From 5c3e92a1419c27f79c2cb7a47af55dfd846357fa Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sun, 26 Sep 2021 21:29:25 +0200
Subject: [PATCH] Remove XEmacs and ancient Emacs compat code
* lisp/ox-html.el (org-html
Hi org-mode,
Stefan Kangas writes:
> As a heads up, Emacs is getting ready to cut the emacs-28 branch in
> preparation of the upcoming release of Emacs 28.1:
>
> https://lists.gnu.org/archive/html/emacs-devel/2021-07/msg00812.html
>
> It would be good if we could mer
Marco Wahl writes:
> Thy nittpicker!
“This above all: to thine own self be true,
And it must follow, as the night the day,
Thou canst not then be false to any man.”
Please find attached another clean-up patch that fixes a small number of
typos.
From 2619a525d025a8d4359cff440264c1fd3e9581c8 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Thu, 16 Sep 2021 21:58:35 +0200
Subject: [PATCH] ; Fix some typos
---
doc/org-manual.org | 4 ++--
etc/ORG-NEWS
The attached patch cleans up some style errors in docstrings and
comments that were found by checkdoc.
From 655c099b10d542207493580115789f3cbeb8b064 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Thu, 16 Sep 2021 12:32:43 +0200
Subject: [PATCH] ; Various minor docfixes found by checkdoc
[Cross-posted to orgmode-emacs and emacs-devel. Please use "Reply to all".]
Hi org-mode,
As a heads up, Emacs is getting ready to cut the emacs-28 branch in
preparation of the upcoming release of Emacs 28.1:
https://lists.gnu.org/archive/html/emacs-devel/2021-07/msg00812.html
It would be g
The attached patch fixes some incorrect keybindings in worg.
I'd recommend that someone takes a look at all the "C-c C-e ..."
keybindings, as there are some that I was unsure about, and may still
be incorrect even after this patch.
0001-Update-some-changed-export-keybindings.patch
Description: B
In Emacs, we have made all the `foo-load-hook' variables obsolete in
favor of `with-eval-after-load'. The attached patch does the same for
org-mode.
From dcf7bfa11a2d27ca9fd44d8fd11440e033b2c567 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Fri, 7 May 2021 14:50:48 +0200
Subje
Please find attached a small cleanup patch to org-agenda.el.
From 16224c9730fe2403d280fc3390ed700ce39c00ae Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sat, 17 Apr 2021 01:45:31 +0200
Subject: [PATCH] Remove diary-list-entries Emacs 21 compat code
* lisp/org-agenda.el (org-get-entries-from
Please find attached a minor cleanup patch.
From 7fcad2bd12ea1833db72494e799df64a5576c6fa Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Tue, 30 Mar 2021 16:19:06 +0200
Subject: [PATCH] Remove redundant #' around lambdas
* contrib/lisp/org-choose.el (org-choose-get-highest-mark-index)
Kyle Meyer writes:
> Pushed (8cc992f7b).
Thanks. Here's a followup patch that converts most remaining http-links
to https. All of them have been manually tested to avoid breakage.
From 0f5a6cd7dcd540daf529a23da6a59a31f2723e87 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sun
The attached patch updates all links to gnu.org to use https instead of
http. (Such a change was made in Emacs itself already in 2017.)
From b68b11fcb6d840fdc9046c4b8ddee34e28665f72 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Sat, 20 Mar 2021 08:27:57 +0100
Subject: [PATCH] Prefer HTTPS
:00 2001
From: Stefan Kangas
Date: Tue, 2 Feb 2021 16:35:48 +0100
Subject: [PATCH] Remove Emacs 21 compat code for bookmark-after-jump-hook
* lisp/org-compat.el (bookmark-after-jump-hook): Remove Emacs 21
compat code.
---
lisp/org-compat.el | 9 +
1 file changed, 1 insertion(+), 8
I'm trying to reduce the number of files in the Emacs source tree where
lexical-binding is nil. It would be nice if we could fix org-version.el
and org-install.el, like in the attached patch.
Thanks in advance.
From c1d8378074bde48528943b36b38cbb5b3c058b21 Mon Sep 17 00:00:00 2001
From: S
Neil Jerram writes:
>> I've been working on removing redundant `function' around `lambda' in
>> Emacs core,
>
> I'm slightly curious about the history and reasoning around this. If I
> understand correctly, (lambda ...) on its own has always worked, and it's
> never been strictly necessary to ad
Lennart Borgman writes:
> On Sun, Nov 28, 2010 at 8:01 PM, Stefan Monnier
> wrote:
>>> Could we please add a replacement for 'htmlize-region-for-past using
>>> htmlfontify?
>>
>> I don't know what is "htmlize-region-for-past(e?)". Care to give us
>> some context?
>
> I have never used it, but
Kyle Meyer writes:
> All these look good to me except this unrelated whitespace change, which
> actually touches the change ported from your 61dca6e92a (Don't quote
> lambdas in several places, 2020-11-14) in the Emacs repo.
I must have included that part by mistake, sorry about that.
> Org fil
ae4bed2468 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Tue, 17 Nov 2020 17:35:49 +0100
Subject: [PATCH] Remove redundant 'function's around lambda
* contrib/lisp/org-secretary.el (join):
* contrib/lisp/ox-taskjuggler.el (org-taskjuggler-project-plan):
* lisp/org-clock.el (org-resolv
y either install a recent version
of Org mode or wait until it is packaged and released with Emacs 28.
I'm therefore closing the Emacs bug now.
Best regards,
Stefan Kangas
ll you rebind the key?
Thanks.
Best regards,
Stefan Kangas
Kyle Meyer writes:
> nitpick: Could you update the docstring to explicitly mention STR and to
> describe NEGATE?
Fixed in the attached patch.
> Thanks for the patch.
Thanks for reviewing.
Best regards,
Stefan Kangas
From 5a9a7d810e174dfad30a6ec657b39cbe83879f94 Mon Sep 17 00:00:00
lved doing more of the heavy lifting
manually using org-agenda-filter-apply.
Best regards,
Stefan Kangas
From 83e67c647d4bfd3e30f8e6e96e77a4192e10f898 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Thu, 21 May 2020 07:24:49 +0200
Subject: [PATCH] New function org-agenda-filter-set
* lisp/org
Please find attached a small patch to fix a typo. I have signed
papers with the FSF for Emacs.
Best regards,
Stefan Kangas
>From d23d79344a29f53e684b4993e056145007f906f5 Mon Sep 17 00:00:00 2001
From: Stefan Kangas
Date: Tue, 18 Feb 2020 07:24:33 +0100
Subject: [PATCH] org-agenda.el: Fix t
Provided there is no org-mode functionality loaded when you install
> a later version with package.el, it works fine.
As far as I understand, the bug in package.el is that you can't always
successfully install a later version of a package after it has been
loaded. In this case, Org-mode fails to in
tefan Monnier and others has pointed out what needs
to be done: now we need to figure out how to do it.
Best regards,
Stefan Kangas
om this should be reported as a bug
> (especially if it can be reproduced).
I fully agree. If package.el has a bug, we should fix it.
See also the previous discussion here:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125
Best regards,
Stefan Kangas
ved Org-mode from Emacs core
with the sole motivation to band-aid an issue with upgrading packages
in package.el.
So I would put your above argument more bluntly: removing Org-mode
from Emacs core would be to sweep the problem under the rug.
package.el is still broken.
Best regards,
Stefan Kangas
76 matches
Mail list logo
