Re: Code Review Request: Step 1 for [FR] Allow emojis in tags (was: emojis in tags?)

2025-05-20 Thread Shuo Shen
On Tue, May 13, 2025 at 10:28 AM Ihor Radchenko wrote: > > --- a/lisp/ol-bibtex.el > > +++ b/lisp/ol-bibtex.el > > @@ -107,6 +107,7 @@ > > > > ;;; Code: > > > > +(require 'org) > > Please don't. (require 'org) is to be avoided. We have enough cyclic > dependencies to handle already. Just use (de

Re: Code Review Request: Step 1 for [FR] Allow emojis in tags (was: emojis in tags?)

2025-05-12 Thread Shuo Shen
s Org codebase and see. All these instances should be changed and ideally use the regexp constants instead of hard-coded constants. Great call out! Done in this new patch. On Sun, May 11, 2025 at 9:09 AM Ihor Radchenko wrote: > > Shuo Shen writes: > > > This is the first patch

Code Review Request: Step 1 for [FR] Allow emojis in tags (was: emojis in tags?)

2025-05-09 Thread Shuo Shen
This is the first patch for the feature request: [FR] Allow emojis in tags (was: emojis in tags?) (https://list.orgmode.org/orgmode/87wn4pdarh.fsf@localhost/) It's my first diff. I'm trying to get an understanding of code as well as the process at the same time, and don't want to get things compli