[PATCH] org-contacts.el: Use `bound-and-true-p' to check (unbound) var

2021-01-04 Thread David Florness
* org-contacts.el (org-contacts-link-store): Use `bound-and-true-p' to check the truthiness of org-id-link-to-org-use-id, which may or may not be bound depending on whether org-id has been loaded. This simplifies the code. --- Thank you, Kyle. This patch should do the trick. I'm always happy to

[PATCH v2] org-contacts.el: Only use org-id-store-link if org-id is loaded

2021-01-04 Thread David Florness
Fixes bug introduced in 6b83c6e4e that made org-contacts-anniversaries error if org-id was not loaded. --- v1 -> v2: Stefan Monnier made a good suggestion to use bound-and-true-p instead here: https://lists.gnu.org/r/emacs-devel/2021-01/msg00257.html Alternatively, we could autoload org-id-link-to

Re: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded

2021-01-04 Thread David Florness
David Florness writes: > Anyways, mu4e has an action function called > `mu4e-action-git-apply-patch' [0] for this. If you setup this action with I meant `mu4e-action-git-apply-mbox' here. -- David signature.asc Description: PGP signature

Re: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded

2021-01-04 Thread David Florness
miles christopher writes: > I applied your patch, thanks. I don't want to use Gmail web UI or find > out email URL in mailing list archive. I'm using mu4e. Is there a > convenient simple way for mu4e user? Oh cool, I use mu4e also :) I guessed you were using the Gmail UI since you have a Gmail a

Re: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded

2021-01-03 Thread David Florness
miles christopher writes: > Thanks for your patch. :smile: > > Can you send patch file as attachment? I don't know how to apply patch in > email body. Hi Miles, If you download the raw email message (which you should be able to do in the Gmail UI) you can apply the patch like so: git am <

[PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded

2021-01-03 Thread David Florness
Fixes bug introduced in 6b83c6e4e that made org-contacts-anniversaries error if org-id was not loaded. --- Alternatively, we could autoload org-id-link-to-org-use-id. If you all would prefer this, let me know and I can send a v2 patch. 6b83c6e4e was found using git-blame. contrib/lisp/org-conta