[PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

2024-03-10 Thread Aaron L. Zeng
* lisp/ob-shell.el (org-babel-shell-initialize): Override explicit-shell-file-name in addition to shell-file-name. When a session with shell source blocks, execution calls `shell', which checks `explicit-shell-file-name' variable before `shell-file-name', to determine what shell to run. If the us

[PATCH] Make predicates non-interactive

2023-03-22 Thread Aaron L. Zeng
Predicates like `org-first-sibling-p' are no use when called interactively, and should not appear in the M-x prompt. TINYCHANGE --- lisp/org.el | 3 --- 1 file changed, 3 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 23cb6012d..20e6ea6d9 100644 --- a/lisp/org.el +++ b/lisp/org.el @@

[PATCH] org--batch-store-agenda-views: Fix treatment of lambda functions

2023-02-07 Thread Aaron L. Zeng
* org-agenda.el (org--batch-store-agenda-views): Fix treatment of lambda functions used as custom agenda commands. `org-agenda-custom-commands' entries may specify a custom function instead of a symbol like `tags-todo'. `org--batch-store-agenda-views' behaved differently from `org-agenda' when tha

[PATCH] org--batch-store-agenda-views: Fix treatment of lambda functions

2023-02-06 Thread Aaron L. Zeng
`org-agenda-custom-commands' entries may specify a custom function instead of a symbol like `tags-todo'. `org--batch-store-agenda-views' behaved differently from `org-agenda' when that custom function was defined as a lambda rather than a symbol, incorrectly treating the lambda form as a list of a

[PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-23 Thread Aaron L. Zeng
* org-compat.el (org-string-pad): Add compatibility function `org-string-pad' for `string-pad', introduced in Emacs 28.1. * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather than `string-pad'. Since this is more-or-less just copying string-pad's definition from subr-x.el, I think t

[PATCH] org-agenda-with-point-at-orig-entry: Fix body indentation

2022-06-20 Thread Aaron L. Zeng
--- lisp/org-agenda.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 76f71e33e..021d36657 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -2124,7 +2124,7 @@ argument to `set-category' for each entry it's called agains

[PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer

2022-05-22 Thread Aaron L. Zeng
(I'm resubmitting this patch because my previous submission was in-reply-to another email which I suspect was ignored. Would love to get this relatively simple bug fixed. Thanks!) * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when org-todo-yesterday intends to call org-agenda

[PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer

2022-04-11 Thread Aaron L. Zeng
* lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when org-todo-yesterday intends to call org-agenda-todo-yesterday with the same interactive arg. Before this change, the command incorrectly set the todo state of the task to blank when called with C-u C-u C-u in an agenda buffer (s

Re: Bug: Infinite loop in org-agenda-dim-blocked-tasks

2021-05-10 Thread Aaron L. Zeng
(Sorry, I am resending this email because I found out gmail doesn't support In-Reply-To in mailto: links). Unfortunately, I think this bug is still there (I also didn't see any commits addressing it, but I could have missed it in the log somewhere). I tried the master branch but was still able to

[PATCH] ol.el: Fix confusing variable name

2021-04-29 Thread Aaron L. Zeng
* ol.el (org-link--open-help): Fix a confusing variable name. No behavior changes. TINYCHANGE --- lisp/ol.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/ol.el b/lisp/ol.el index 62ea6d2bc..617223cb5 100644 --- a/lisp/ol.el +++ b/lisp/ol.el @@ -1325,8 +1325,8 @@ P