Re: [PATCH v5] Inline image display as part of a new org-link-preview system

2024-09-17 Thread Karthik Chikmagalur
Next version of patch attached. > 1. I run preview on the whole buffer > 2. M-x list-timers shows the timer, and it is ugly: > * 10.0s - #f(compiled-function () # > > [...] > > 10+ sec] >- So, no closures please. Use normal named functions Done. Only one entry per buff

Re: package submission : ob-sql-session

2024-09-17 Thread Phil Estival
Hi Adam, * [2024-09-18 00:25] Adam Porter: Hi Phil, On 9/17/24 05:00, Phil Estival wrote: Also, for org-sql-session (which sounds very useful), it would be good to compare and contrast it with the package it's meant to supersede. The following comparison was added to the readme file. ob

Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.

2024-09-17 Thread lra
And it is *with* the attachment. Kind regards, LRA Sep 18, 2024, 02:26 by l...@phdk.org: > Hello org-mode mailing list > > Long time, first time. This is just a tiny patch fixing a regression > in org-persist--find-index that was missed in the 95f77669e0 bugfix. It > affects > calls to org-pe

Re: org-cut-subtree should respect org-ctrl-k-protect-subtree

2024-09-17 Thread Dan Drake
I like that idea. It's consistent, uses "prior art", so to speak, and most of all , archiving involves cutting the subtree, so it's a very similar change to the buffer / structure. On Sun, Sep 15, 2024, 07:44 Ihor Radchenko wrote: > Dan Drake writes: > > > "AFAIU, what you are struggling with i

Re: packages submissions : ob-sql-session and org-blog

2024-09-17 Thread Adam Porter
Hi Phil, On 9/17/24 05:00, Phil Estival wrote: Also, for org-sql-session (which sounds very useful), it would be good to compare and contrast it with the package it's meant to supersede. The following comparison was added to the readme file. ob-sql-mode : - is very simple : forward the sql s

Re: Org-Capture Window Behavior

2024-09-17 Thread Amol Vaidya
(Apologies for replying to this twice Ihor, forgot to reply-all last time.) The linked video was from an emacs -q, so I have made no modifications to display-buffer-alist, and my understanding is that emacs -q is equivalent to an empty init file. If that's not correct, I'm not sure what kind of re

Re: Org-Capture Window Behavior

2024-09-17 Thread Ihor Radchenko
Amol Vaidya writes: > I have tested this with a clean installation of Emacs, where I > installed Org mode 9.7, but I am still encountering the same behavior. > > For reference, I’ve attached a screen recording that demonstrates the > issue. I’ve also verified that Org 9.7 is being used, as shown

Re: [BUG] export blocks no longer fontifying [9.7.10 (release_9.7.10 @ /Users/ben/Scripts/emacs/lisp/org/)]

2024-09-17 Thread Ihor Radchenko
Benjamin McMillan writes: > I attach the patch here. Thanks! > However, I have two questions. > First, I am not certain that I set up the repository correctly, because > when I run "make test" it generates 55 unexpected failures. This without > making any changes. > (The patch submitted here do

Re: Proposal: Change publication timestamps

2024-09-17 Thread Ihor Radchenko
Jens Lechtenboerger writes: >>> Ideally, it would be nice to have tests as well. >> >> I added test cases in the attached patch. > > I amended the commit message. I hope this to be ready for inclusion. Thanks! Applied, onto main, with a small amendment to the commit message. https://git.savanna

Re: [BUG] What about excluding .dir-locals.el from GNU ELPA tarball?

2024-09-17 Thread Morgan Willcock
Ihor Radchenko writes: >> I believe it is up to the file to opt-out of compilation. > > That's true, but .dir-locals is a special file. So, I expected Emacs to > treat it specially during compilation as well. To not break old, > no-longer-maintained packages, if nothing. I guess the counter argu

Re: [PATCH v4] Inline image display as part of a new org-link-preview system

2024-09-17 Thread Ihor Radchenko
Karthik Chikmagalur writes: >> It means that you are scheduling every single preview batch to fire at >> the same time. I think that the timers here should run sequentially - >> (1) fire the first batch without delay; (2) wait org-link-preview-delay >> and fire the next batch; (3) ... > > Done, a

Differentiating org element properties from built-ins?

2024-09-17 Thread tomas
Hi, Orgxperts assume I have something like this: ** Some heading :properties: :foo: some value for foo :bar: some value for bar :end: Now, when I do (org-element-properties-mapc (lambda (k v) (message "%s -> %s" k v)) (org-element-at-point)) I do see foo and bar (well, OK

Re: [BUG] export blocks no longer fontifying [9.7.10 (release_9.7.10 @ /Users/ben/Scripts/emacs/lisp/org/)]

2024-09-17 Thread Benjamin McMillan
I attach the patch here. However, I have two questions. First, I am not certain that I set up the repository correctly, because when I run "make test" it generates 55 unexpected failures. This without making any changes. (The patch submitted here does not generate any new failures.) Second, the e

Re: Org-cite: Replace basic follow-processor with transient menu?

2024-09-17 Thread Tor-björn Claesson
Hi and thanks for replying! Ihor Radchenko writes: > > I do think that having extended menus for org-open-at-point could be > useful. Not by default, but, for example, with a prefix argument. > This is a good point, but of much larger scope than just replacing the follower of the basic citation-

[BUG] org-id-find might change the major-mode of a buffer [9.8-pre (release_9.7.8-713-g62cbac @ /home/viz/lib/emacs/straight/build/org/)]

2024-09-17 Thread Visuwesh
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.

Re: packages submissions : ob-sql-session and org-blog

2024-09-17 Thread Phil Estival
* [2024-09-11 05:01] Adam Porter: Hi Phil, A quick, initial suggestion: it would be good to reformat the Lisp code in both projects, as I see several cases of incorrect indentation, hanging parens, extra blank lines, etc, and some of them would make the code hard to read.  For my Lisp editi