Re: How to organize tasks about Worg within Worg documents

2024-04-01 Thread Adam Porter
On 4/1/24 06:34, Ihor Radchenko wrote: What we may do is the following: 1. Make sure that we stick to the recommended todo keywords, so that todo keywords have a known-in-advance class in html export. 2. Put notes into LOGBOOK drawers (set `org-log-into-drawer' in WORG dirlocals) 3. Chan

Re: [BUG] (org-element-context) caused (re-search-forward ) + (match-string-no-properties 1) returned matched data wrong

2024-04-01 Thread Ihor Radchenko
"Christopher M. Miles" writes: > Re: [BUG] (org-element-context) caused (re-search-forward ) + > (match-string-no-properties 1) returned matched data wrong `org-element-context' does not guarantee that match data is not altered. You need to wrap it into `save-match-data' if necessary. : or

Re: [PATCH] Re: [BUG] Underlined text in parentheses is not exported correctly

2024-04-01 Thread Ihor Radchenko
Ihor Radchenko writes: > So, the attached patch is changing the priority of the parsing. > Maybe Nicolas knows some tricky cases when the patch makes things wrong, > but those cases are certainly not covered by tests. No objections. Applied, onto main, adding ORG-NEWS entry. https://git.savannah

Re: [PATCH] lisp/org-capture.el: Simplify 'org-capture-get-indirect-buffer'

2024-04-01 Thread Ihor Radchenko
Morgan Smith writes: > * lisp/org-capture.el (org-capture-get-indirect-buffer): Simplify by > using 'generate-new-buffer-name'. > ... > - (let ((n 1) (base (buffer-name buffer)) bname) > -(setq bname (concat prefix "-" base)) > -(while (buffer-live-p (get-buffer bname)) > - (setq bn

Re: How to organize tasks about Worg within Worg documents

2024-04-01 Thread Ihor Radchenko
Adam Porter writes: >> May we have some kind of css-based toggle that will enable "developer >> mode", revealing all the todo keywords, inlinetasks, and notes? Then, we >> hide the "unfinished" parts from users by default, but let them see what >> can be contributed? > > I like the idea of a visu

Re: [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command)

2024-04-01 Thread Ihor Radchenko
Max Nikulin writes: >> I have a concern about this test - it will not work on windows or in > > I do not mind to add > > (skip-unless (not (memq system-type '(ms-dos windows-nt > >> non-standard system shells. We should probably disable the test unless >> "printf" can be evaluated in the

Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command

2024-04-01 Thread Ihor Radchenko
Max Nikulin writes: >> I have incorporated the above suggestions into the attached version of >> the patch. > > Thanks, I have not tried the updated patch in action, but it looks like > what I expect. > I would consider explicit mention of stripping quotes > ... I incorporated your suggestions

Re: [BUG] Partially broken Org mode when remote setupfile is unavailable

2024-04-01 Thread Ihor Radchenko
Max Nikulin writes: >> This part is now addressed by >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4255d5dcc > > You are right that a workaround with `org-file-remote-p' would not help. > On the other hand I can reproduce the issue with Emacs-28 and the error > happens in `

Re: [BUG] org-export-table-row-number off by one when special row present [9.6.23 ( @ /home/jet/.config/emacs/elpa/org-9.6.23/)]

2024-04-01 Thread Ihor Radchenko
Jeff Trull writes: > Consider this table: > > ... > org-export-table-row-number correctly returns 3 for the cell containing '4' > (and the target of the formula) > > Now add a column alignment row: > > ... > | || > ... > org-export-table-row-number still returns 3 for the same cell,

Re: [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command)

2024-04-01 Thread Max Nikulin
On 31/03/2024 15:27, Ihor Radchenko wrote: Max Nikulin writes: +(ert-deftest test-org/format-latex-as-html () + "Test shell special characters escaping in `org-format-latex-as-html'." + (let ((org-latex-to-html-convert-command + "printf \"\" %i")) I have a concern about this test -

Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command

2024-04-01 Thread Max Nikulin
On 31/03/2024 15:25, Ihor Radchenko wrote: Max Nikulin writes: I think it is in the right direction. - Manual needs update as well. - I would explicitly stress that quotes causes undefined or even dangerous behavior. See e.g. the last paragraph https://specifications.freedesktop.org/desktop-ent

Re: [BUG] Partially broken Org mode when remote setupfile is unavailable

2024-04-01 Thread Max Nikulin
On 30/03/2024 17:02, Ihor Radchenko wrote: Ihor Radchenko writes: Unexpected errors: - When point is on any non-empty line, RET is broken save-excursion: Wrong type argument: stringp, nil - The link is not fontified (it is parsed properly however and even may be opened). This is because `fi