Re: [BUG] org-capture-kill: doesn't remove the right text region

2022-07-23 Thread Ihor Radchenko
Caleb Chase writes: > I discovered a bug with org-capture and org-capture kill when > canceling an item or plain type template on a heading that has only an > empty line for content. Minimal reproduction is as follows: The fix is attached. The reason why this bug is happening is `org-capture-emp

Re: [PATCH] org.el: Use `call-process' to launch external viewers (was: Re: [BUG] org-open-file immediately termininates when calling xdg-open that calls emacsclient)

2022-07-23 Thread Ihor Radchenko
Max Nikulin writes: >> I have reported this to Emacs. The more precise steps are in >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55672 > > As expected, nobody wishes to dig into obscure X11 issue. > > You may try the attached patch. I do not consider it as unambiguous > improvement since alm

Re: [BUG] Avoid folding drawers using `org-clock-goto'

2022-07-23 Thread Tor Kringeland
Ihor Radchenko writes: > Could you please elaborate why you prefer not folding drawers in > `org-clock-goto'? If I already unfolded a drawer (for example with notes), then I want to keep it open, at least as long as the heading itself is unfolded. For example if I have #+begin_example * some t

Re: [BUG] Avoid folding drawers using `org-clock-goto'

2022-07-23 Thread Ihor Radchenko
Tor Kringeland writes: > When calling `org-clock-goto' the drawers of the heading it goes to are > closed, if they're open. It may or may not be a bug depending on your preferences. Though we indeed changed this default as a side effect of other change. See https://orgmode.org/list/87tu9tpnbt.fs

[PROPOSED-PATCH] ox-publish: fix typo in function name

2022-07-23 Thread Paul Eggert
* lisp/ox-publish.el (org-publish-cache-mtime-of-src): Rename from org-publish-cache-ctime-of-src, since it has always cached mtime not ctime. All uses changed. --- lisp/ox-publish.el | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lisp/ox-publish.el b/l

[BUG] Avoid folding drawers using `org-clock-goto'

2022-07-23 Thread Tor Kringeland
When calling `org-clock-goto' the drawers of the heading it goes to are closed, if they're open.

Re: [PATCH] oc-csl: Add support for sub-bibliographies

2022-07-23 Thread András Simonyi
Dear All, On Sat, 23 Jul 2022 at 05:59, Ihor Radchenko wrote: > Could you please create a dedicated subsection under "15 Citation> handling" > instead of documenting PRINT_BIBLIOGRAPHY together with export > processors? The section should contain a general overview of what > PRINT_BIBLIOGRAPHY d

Improvements in the default LaTeX preamble (was: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists)

2022-07-23 Thread Juan Manuel Macías
Max Nikulin writes: > My vote is to configure babel by default if it is possible to provide > default preamble that allows reasonable quality of PDF for simple Org > documents with no explicit configuration. > > Ideally, the following should be possible out of the box. When no > advanced features

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Juan Manuel Macías
Hi Ihor and Kai, Ihor Radchenko writes: > Hmm. You are actually right. > Juan, can you please take a look. It looks like you missed > "org-latex--format-spec" in the patch. It should use the new > org-latex-language-alist variable instead. Attached a new patch to fix (I hope) the org-latex-langu

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Max Nikulin
On 23/07/2022 20:06, Ihor Radchenko wrote: Max Nikulin writes: If it still fails, could you try isolating whether it's a specific `should' clause which is the problem, if it fails with any of them? It is `map-do' that causes the problem. Maybe earlier implementation in Emacs-26 has some pecul

Re: Recent folding issues

2022-07-23 Thread Jack Kamm
Ihor Radchenko writes: > Thanks for another detailed report! > Fixed on main via 39005dc09. > > Let me know if you notice any other inconsistencies. Thanks very much Ihor! Much appreciated :) I'll let you know if I notice any other issues -- everything seems to be working well so far. Best, J

Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Max Nikulin
On 23/07/2022 12:01, Ihor Radchenko wrote: Juan Manuel Macías writes: Here is a new version of the patch, with the fixes added. Thanks! Considering that the followup discussion deviated from the substance of the patch towards related design issues, I believed that the subject of discussion

Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Max Nikulin
On 22/07/2022 21:07, Juan Manuel Macías wrote: Forget this. On second thought, I think that the option you proposed "#+LaTeX_Header: % \usepackage{babel}" is much better. (I don't know where my head was and I didn't remember there was a string-match, so your suggestion is the shortest way. Howe

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Juan Manuel Macías
Hi Kai, Kai von Fintel writes: > I do think that the code on lines 1864 and 1865 of =ox-latex.el= > (https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el#n1864) > should not use the old variable names. Since you’ve now defined the > old variables in =org-compat.el=, my expor

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Kai von Fintel writes: >>> (defun org-latex--format-spec (info) >>> "Create a format-spec for document meta-data. >>> INFO is a plist used as a communication channel." >>> (let ((language (let ((lang (plist-get info :language))) >>> (or (cdr (assoc-string lang org-latex-babel-

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Kai von Fintel
On 23 Jul 2022, at 17:22, Ihor Radchenko wrote: > Kai von Fintel writes: > > Debugger entered--Lisp error: (void-variable > org-latex-babel-language-alist) > org-latex--format-spec( >>> >>> org-latex-babel-language-alist is the new variable introduced in the >>> patch. You seem t

Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Juan Manuel Macías writes: > Ihor Radchenko writes: > > Thanks, Ihor. And sorry again for my typos... No problem. > If it's okay with you, I can send another patch with the updated > information in NEWS and the Manual. And we can continue the subsequent > discussion related of babel, polyglossi

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Kai von Fintel writes: Debugger entered--Lisp error: (void-variable org-latex-babel-language-alist) org-latex--format-spec( >> >> org-latex-babel-language-alist is the new variable introduced in the >> patch. You seem to be loading "mixed" Org versions - built-in + latest. > > No

Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Juan Manuel Macías
Ihor Radchenko writes: > Thanks! Considering that the followup discussion deviated from the > substance of the patch towards related design issues, I have decided to > marge the patch as is. We can decide on handling AUTO staff later - it > would be a major change to remove and the details of an a

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Kai von Fintel
On 23 Jul 2022, at 16:59, Ihor Radchenko wrote: > Kai von Fintel writes: > >> I believe that that this patch has made it impossible to export to latex, >> because the function =org-latex--format-spec= in =ox-latex.el= still refers >> to the old variables, which are now not bound: >> >>> Debugge

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Ihor Radchenko
Kai von Fintel writes: > I believe that that this patch has made it impossible to export to latex, > because the function =org-latex--format-spec= in =ox-latex.el= still refers > to the old variables, which are now not bound: > >> Debugger entered--Lisp error: (void-variable org-latex-babel-lan

BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-23 Thread Kai von Fintel
I believe that that this patch has made it impossible to export to latex, because the function =org-latex--format-spec= in =ox-latex.el= still refers to the old variables, which are now not bound: > Debugger entered--Lisp error: (void-variable org-latex-babel-language-alist) > org-latex--format

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Ihor Radchenko
Max Nikulin writes: >> If it still fails, could you try isolating whether it's a specific >> `should' clause which is the problem, if it fails with any of them? > > It is `map-do' that causes the problem. Maybe earlier implementation in > Emacs-26 has some peculiarities. It is the version availa

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-23 Thread Max Nikulin
On 23/07/2022 14:48, Hugo Heagren wrote: I've already assigned copyright to the FSF for work on Emacs (see attached certificate). Do I need to do anything else for org-mode in particular? Great, I hope, it is enough, but my answer is not authoritative. Emacs-26.3: make test-dirty BTEST_RE=te