Hi Mark,
On Monday, October 14th, 2024 at 16:38, Mark Wielaard wrote:
>
>
> There isn't much code in this file. What kind of build issue are you
> seeing without this? Does config.h contain some construct that affects
> the build of this file?
Like I mentioned in the cover letter, we inco
Hi again,
On Monday, October 14th, 2024 at 17:30, Mark Wielaard wrote:
>
>
> If we are trying to be more consistent then I think I would prefer we
> use putchar, puts, and printf, instead of adding stdout to all these
> calls.
I don't really have a preference, you could even throw out th
ed program regions,
using exported locking primitives.
and these precautions were never done.
Use the standard forms of these print functions.
There is inconsistent use of fputc_unlocked() with putc_unlocked(),
so consistently use the safer fputc() instead.
Signed-off-by: Michael Pratt
-
tools.
The first 4 patches are very simple so I'm hoping they can be merged ASAP.
The last 2 patches are less critical, especially the last one
which is just an organizational step. If the last 2 patches
are not acceptable, they can be dropped or revisited after the release.
Thanks,
MCP
Mi
f the Definitions".
The %top block is non-POSIX, so using it reinforces
the requirement of "flex" over a standardized "lex" even more.
* libcpu/i386_lex.l (%top): add flex %top block
and move config.h header inclusion to it.
Signed-off-by: Michael Prat
primitives.
and this was never done.
There is inconsistent use of fputc_unlocked()
mixed with putc_unlocked() and putchar_unlocked(),
so consistently use the safer fputc() instead.
Signed-off-by: Michael Pratt
---
libasm/asm_align.c | 4 +-
libcpu/i386_parse.y | 4 +-
libebl/eblobjnote.c | 4
nditional definition.
Signed-off-by: Michael Pratt
---
libdw/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libdw/Makefile.am b/libdw/Makefile.am
index 5363c02a..4b9c4413 100644
--- a/libdw/Makefile.am
+++ b/libdw/Makefile.am
@@ -97,7 +97,6 @@ libdw_a_SOU
nt.
While this doesn't guarantee an error will not occur
in all cases, it does guarantee that it will not occur
from a clean build state.
* src/Makefile.am: Add compilation dependency between
the stack and srcfiles binaries.
Signed-off-by: Michael Pratt
---
src/Makefile.am | 1
This is the last remaining C source file as of this commit
without the standard conditional inclusion of config.h
as the very first header.
* lib/next_prime.c: add missing config.h header.
Signed-off-by: Michael Pratt
---
lib/next_prime.c | 4
1 file changed, 4 insertions(+)
diff
grepping for puts() can clash with
words like "inputs" and "outputs", and that putc() can be a macro
while fputc() is the safer function.
While at it, adjust spacing syntax and punctuation for consistency.
Signed-off-by: Michael Pratt
---
libcpu/i386_disasm.c | 2
Hi Aaron,
On 10/22/24 4:45 PM, Aaron Merey wrote:
> Hi Michael,
>
> On Tue, Oct 15, 2024 at 11:10 AM Michael Pratt wrote:
> > It would be nice to have patch 5 before release,
> > for patch 6 doesn't matter if or when to me.
> >
> > Let me know i
EXTRA_DIST.
Signed-off-by: Michael Pratt
---
backends/Makefile.am | 3 ++-
debuginfod/Makefile.am | 5 +++--
lib/Makefile.am| 1 +
libasm/Makefile.am | 4 +++-
libcpu/Makefile.am | 6 +++---
libdw/Makefile.am | 3 ++-
libdwelf/Makefile.am | 2 +-
libdwfl/Makefile.am
Hi, thanks for the reply,
On Friday, October 11th, 2024 at 15:09, Aaron Merey wrote:
>
> I believe this issue was recently fixed in commit b426c4db31e7.
Yeah, this looks like it handles the problem more directly,
thanks for pointing it out.
However, it would be nice if DEFAULT_INCLUDES was
Hi Aaron,
The first 3 patches of the series are pretty simple and helpful.
I would like to see them in the next release, do they look ok?
Without the first 2, we actually experience build errors
due to config.h not being included or being included too late.
The 3rd one prevents an error with our
re.
* Makefile.am: remove variables and custom clean target.
* config/eu.am: remove clean variables, add variables
and custom clean target based on removed definitions.
Fixes: b2f225d6b ("Consolidate and add files to clean target variables")
Reported-by: Mark Wielaard
Signed
fig/eu.am: add coverage target to .PHONY list
* tests/Makefile.am: remove .PHONY list in conditional
Signed-off-by: Michael Pratt
---
Makefile.am | 1 -
config/eu.am | 3 ++-
tests/Makefile.am | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makefile.
m that are defined in Makefile.am,
so there are no other conflicts or overrides between the two.
Signed-off-by: Michael Pratt
---
Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 92130b57..9a8e5a52 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -
Hi Mark,
> Since b2f225d6bff8 ("Consolidate and add files to clean target variables")
> autoreconf (automake) produces these warnings:
oops, sorry...
> This is because config/eu.am defines a default CLEANFILES. So those
> Makefile.am files should add to CLEANFILES with += instead of
> redef
Hi Mark,
On 11/21/24 7:44 PM, Mark Wielaard wrote:
> Hi Michael,
>
> On Tue, Nov 19, 2024 at 04:18:17AM +, Michael Pratt wrote:
> >
> > > This is because config/eu.am defines a default CLEANFILES. So those
> > > Makefile.am files should add
f/Makefile.am: Likewise.
* libdwfl/Makefile.am: Likewise.
* libebl/Makefile.am: Likewise.
* libelf/Makefile.am: Likewise,
and set object lists to manifest contents.
* src/Makefile.am: Likewise.
Signed-off-by: Michael Pratt
---
.gitignore | 1 +
backends/Makefil
20 matches
Mail list logo
