Re: [PATCH 6/6 v2] doc: Add elf_kind.3

2025-05-14 Thread Aaron Merey
On Wed, May 14, 2025 at 10:16 AM Mark Wielaard wrote: > > Hi Aaron, > > On Mon, 2025-05-12 at 20:33 -0400, Aaron Merey wrote: > > v2: Mention ar(1) and that elfutils libelf does not support COFF object > > files. > > > > On Thu, May 1, 2025 at 1:17 PM Mark Wielaard wrote: > > > > > > > +.SH SEE A

Re: [RFC] tests/run-stack-live-test.sh: prototype 'live' eu-stack testing

2025-05-14 Thread Serhei Makarov
On Wed, May 14, 2025, at 9:54 AM, Mark Wielaard wrote: > I like the testrun_compare_fuzzy name. Nice, though I might have to end up with several versions of the function (testrun_compare_fuzzy_stack, testrun_compare_fuzzy_stacktrace, ...). It's an open question whether they need to be generalize

Re: [RFC] tests/run-stack-live-test.sh: prototype 'live' eu-stack testing

2025-05-14 Thread Serhei Makarov
On Wed, May 14, 2025, at 10:30 AM, Aaron Merey wrote: > If it's not quite generic enough for test-subr.sh we can always > include this in a stacktrace-subr.sh file, for instance. Yeah, I'm thinking this is the more likely outcome. >> +# >> +# TODO(REVIEW): Better shell-isms for comparing file a

☠ Buildbot (Sourceware): elfutils - failed test (failure) (main)

2025-05-14 Thread builder
A new failure has been detected on builder elfutils-debian-ppc64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/63/builds/509 Build state: failed test (failure) Revision: 11c54284514498c29147972ddbf35eac4c95039c Worker: debian-ppc64

☺ Buildbot (Sourceware): elfutils - build successful (main)

2025-05-14 Thread builder
A restored build has been detected on builder elfutils-debian-ppc64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/63/builds/510 Build state: build successful Revision: c18a9ef154bf5583183443a2bf7de8f4cea89d8f Worker: debian-ppc64 B

Re: [RFC] tests/run-stack-live-test.sh: prototype 'live' eu-stack testing

2025-05-14 Thread Mark Wielaard
Hi Serhei, On Thu, 2025-05-08 at 18:28 -0400, Serhei Makarov wrote: > Missing a few pieces, but worth sharing as an RFC. My idea is to > ensure better test coverage for eu-stack and then > eu-stacktrace+libdwfl_stacktrace by running against a live process > with known content, stopped at a known l

Re: [PATCH 1/6] doc/Makefile.am: Sort manpages in alphabetical order

2025-05-14 Thread Mark Wielaard
Hi Aaron, Yes, please. Thanks, Mark

Re: [PATCH 2/6 v2] doc: Add elf_end.3

2025-05-14 Thread Mark Wielaard
Hi Aaron, On Mon, 2025-05-12 at 20:33 -0400, Aaron Merey wrote: > v2: Mention elf arg may be NULL. Looks good. > On Wed, Apr 30, 2025 at 1:18 PM Mark Wielaard wrote: > > > > So we do have a tiny elf_begin.3 man page, but it doesn't really > > describe anything. The above seems a technically co

Re: [PATCH 3/6 v2] doc: Add elf_fill.3

2025-05-14 Thread Mark Wielaard
Hi Aaron, On Mon, 2025-05-12 at 20:33 -0400, Aaron Merey wrote: > v2: Mention fill value only applies to new gaps and set Thread Safety > atrribute to 'MT-Unsafe race' Looks good. Thanks, Mark

Re: [PATCH 4/6] doc: Add elf_getbase.3

2025-05-14 Thread Mark Wielaard
Hi Aaron, On Mon, 2025-05-12 at 20:33 -0400, Aaron Merey wrote: > v2: mention that base offset returned is always 0 for non ELF_K_AR > kinds. Also mention elf_getaroff and elf_rawelf. Looks good. Thanks, Mark

Re: [PATCH 5/6 v2] doc: Add elf_hash.3

2025-05-14 Thread Mark Wielaard
Hi Aaron, On Mon, 2025-05-12 at 20:33 -0400, Aaron Merey wrote: > v2: Mention use with SHT_HASH and clarify that only the lower 32 bits of > the return value are used. Looks good. Thanks, Mark

Re: [PATCH 6/6 v2] doc: Add elf_kind.3

2025-05-14 Thread Mark Wielaard
Hi Aaron, On Mon, 2025-05-12 at 20:33 -0400, Aaron Merey wrote: > v2: Mention ar(1) and that elfutils libelf does not support COFF object > files. > > On Thu, May 1, 2025 at 1:17 PM Mark Wielaard wrote: > > > > > +.SH SEE ALSO > > > +.BR libelf (3), > > > +.BR elf (5) > > > > elf.5 doesn't des

Re: [RFC] tests/run-stack-live-test.sh: prototype 'live' eu-stack testing

2025-05-14 Thread Aaron Merey
On Thu, May 8, 2025 at 6:28 PM Serhei Makarov wrote: > > Missing a few pieces, but worth sharing as an RFC. My idea is to > ensure better test coverage for eu-stack and then > eu-stacktrace+libdwfl_stacktrace by running against a live process > with known content, stopped at a known location, and