Re: [PATCH] src: fix DEREF_OF_NULL.RET.STAT in readelf.c in

Hi Anton, On Thu, Feb 13, 2025 at 07:33:12PM +0300, Anton Moryakov wrote: > Static analyzer reported: > Return value of a function 'elf_strptr' is dereferenced at readelf.c:7171 > without checking for NULL, but it is usually checked for this function > (71/74). > > Corrections explained: > - Add

Re: [PATCH] scr: fix DEREF_OF_NULL.RET.STAT in ar.c

Hi Anton, The subject isn't super helpful unless you know the specific terminology of the statuc analyzer you are using. It would be better to say something like: ar: check whether elf_getarhdr returns NULL On Thu, 2025-02-13 at 18:00 +0300, Anton Moryakov wrote: > Report of the static analyze

Re: [PATCH] src: fix DEREF_OF_NULL.RET in readelf.c

Hi Anton, On Thu, 2025-02-13 at 18:57 +0300, Anton Moryakov wrote: > Report of the static analyzer: > DEREF_OF_NULL.RET Pointer, returned from function 'elf_getarhdr' at > readelf.c:13551, > may be NULL and is dereferenced at readelf.c:13553. > > Corrections explained: > - Added a NULL check fo

Re: [PATCH 2/9 v3] libdw: Add locking to dwarf_getsrcfiles, dwarf_getsrclines, dwarf_macro_getsrcfiles

Hi Aaron, On Wed, Feb 19, 2025 at 11:36:37PM -0500, Aaron Merey wrote: > * libdw/dwarf_getsrcfiles.c (dwarf_getsrcfiles): Use dwarf_lock. > * libdw/dwarf_getsrclines.c (dwarf_getsrclines): Ditto. > * libdw/dwarf_macro_getsrclines.c (dwarf_macro_getsrclines): > Ditto. > >

Re: [PATCH 3/9 v3] libdwP.h: Add locking to str_offsets_base_off

Hi Aaron, On Wed, Feb 19, 2025 at 11:36:38PM -0500, Aaron Merey wrote: > * libdw/dwarf_end.c (cu_free): Free str_off_base_lock. > * libdw/libdwP.h (struct Dwarf_CU): Add str_off_base_lock member. > (str_offsets_base_off): Add locking. > * libdw/libdw_findcu.c (__libdw_inter

Re: [PATCH 2/9 v3] libdw: Add locking to dwarf_getsrcfiles, dwarf_getsrclines, dwarf_macro_getsrcfiles

Hi - > We should make dwarf_getsrcfiles and dwarf_getsrclines independent so > callers that onle need the file table don't need to "pay" for parsing > the whole line table. (I thought we had a bug for that, but cannot > find it now. If you also cannot find it, please let me know and I'll > file a

Re: [patch] PR31862: debuginfod client should cache received x-debuginfod-* headers

Hi Frank, On Fri, Feb 21, 2025 at 3:07 PM Frank Ch. Eigler wrote: > > > commit 082c0a94eed6706753e8019ce348be095deb72f9 (HEAD -> main) > Author: Frank Ch. Eigler > Date: Fri Feb 21 14:33:49 2025 -0500 > > PR31862: debuginfod: client to cache x-debuginfod-* headers > > This feature allo

Re: [PATCH] src: fix DEREF_OF_NULL.RET.STAT in readelf.c in

Hi Anton, On Thu, Feb 13, 2025 at 07:52:00PM +0300, Anton Moryakov wrote: > Static analyzer reported: > Return value of a function 'gelf_getehdr' is dereferenced at readelf.c:12443 > without checking for NULL, but it is usually checked for this function > (53/54). I can see how a static analyzer

Re: [PATCH 1/9 v3] Change type of dwarf_lock from rwlock to mutex

Hi Aaron, On Wed, Feb 19, 2025 at 11:36:36PM -0500, Aaron Merey wrote: > Change type of dwarf_lock to mutex in order to take advantage of > built-in support for recursive locking. > > * lib/locks.h: Add macros for locking, unlocking, initializing > and destroying mutexes. > * li

Re: [PATCH] src: fix DEREF_OF_NULL.RET.STAT in unstrip.c

Hi Anton, On Thu, Feb 13, 2025 at 08:19:44PM +0300, Anton Moryakov wrote: > Static analyzer reported: > Return value of a function 'elf_getdata' is dereferenced at unstrip.c:1977 > without checking for NULL, but it is usually checked for this function > (97/101). > > Corrections explained: > - A

[PATCH] Take latest of archive and file mtime

attached >From dad01d11ce8390f1c32fa39963d6aeb17897a9c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Batlle=20i=20Rossell?= Date: Thu, 27 Feb 2025 14:16:41 +0100 Subject: [PATCH] Take latest of archive and file mtime MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transf