Re: [PATCH 2/5] readelf: Adapt src/readelf -h/-S/-r/-w/-l/-d/-a on mips

2023-08-01 Thread Mark Wielaard
Hi Ying, On Mon, 2023-07-24 at 16:35 +0800, Ying Huang wrote: > Hi Mark, > > > > diff --git a/libebl/eblreloctypecheck.c b/libebl/eblreloctypecheck.c > > > index 80e67ef7..e3c43944 100644 > > > --- a/libebl/eblreloctypecheck.c > > > +++ b/libebl/eblreloctypecheck.c > > > @@ -32,10 +32,14 @@ > > >

Re: [PATCH 2/5] readelf: Adapt src/readelf -h/-S/-r/-w/-l/-d/-a on mips

2023-08-01 Thread Mark Wielaard
Hi Ying, On Tue, 2023-07-25 at 16:15 +0800, Ying Huang wrote: > In file common-reloc.c, hook functions > reloc_type_check/reloc_type_use/reloc_type_name have these codes: > > #ifdef RELOC_TYPE_ID >   reloc = RELOC_TYPE_ID (reloc); > #endif > > And the macro RELOC_TYPE_ID was defined in file bac

Re: [PATCH 2/5] readelf: Adapt src/readelf -h/-S/-r/-w/-l/-d/-a on mips

2023-08-01 Thread Mark Wielaard
Hi Ying, On Thu, Jul 27, 2023 at 02:08:52PM +0800, Ying Huang wrote: > > Can we add a new file mips.h in backends, and move defines of > ELF64_MIPS_R_TYPE/ELF64_MIPS_R_TYPE2/ELF64_MIPS_R_TYPE3 from elf.h > to mips.h? > > And rename the macro name ELF64_MIPS_R_TYPE to ELF64_MIPS_R_TYPE1 in > mips.h