Re: [PATCH] Fix automake warnings

On Thu, 2020-12-10 at 02:34 +0300, Dmitry V. Levin wrote: > Apparently, commit 2f02e81510946a4c8e9157ad0b72d92894b9acd7 that > removed > $(EXEEXT) suffix from shared libraries was incomplete: it missed the > fact that some libraries were included into noinst_PROGRAMS, > resulting > to the following

Re: [PATCH] Fix automake warnings

On Thu, Dec 10, 2020 at 11:09:21AM +0100, Mark Wielaard wrote: > On Thu, 2020-12-10 at 02:34 +0300, Dmitry V. Levin wrote: > > Apparently, commit 2f02e81510946a4c8e9157ad0b72d92894b9acd7 that > > removed > > $(EXEEXT) suffix from shared libraries was incomplete: it missed the > > fact that some lib

Re: [PATCH] Fix automake warnings

Hi Dmitry, On Thu, 2020-12-10 at 13:30 +0300, Dmitry V. Levin wrote: > On Thu, Dec 10, 2020 at 11:09:21AM +0100, Mark Wielaard wrote: > > Very nice. I have one small issue, with automake 1.13.4 when removing > > the lib{asm,dw,elf}_so_SOURCES variables no clean rule is generated > > anymore for th

Re: [PATCH] Fix automake warnings

On Thu, Dec 10, 2020 at 12:28:35PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, 2020-12-10 at 13:30 +0300, Dmitry V. Levin wrote: > > On Thu, Dec 10, 2020 at 11:09:21AM +0100, Mark Wielaard wrote: > > > Very nice. I have one small issue, with automake 1.13.4 when removing > > > the lib{asm

Re: [PATCH] Fix automake warnings

Hi Dmitry, On Thu, 2020-12-10 at 14:52 +0300, Dmitry V. Levin wrote: > On Thu, Dec 10, 2020 at 12:28:35PM +0100, Mark Wielaard wrote: > > > > + * Makefile.am (noinst_PROGRAMS): Rename to noinst_DATA. > > > > + (libasm_so_SOURCES): Remove. > > > > + (CLEANFILES): Add libelf.so. >

Re: [PATCH 1/2] link_map: Pull release_buffer() into file scope

Hi Timm, On Mon, 2020-12-07 at 12:11 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Add a memory_closure struct to > keep the functions clean. Pushed with one fix. > @@ -319,7 +331,7 @@ report_r_debug (uint_fast8_t elfclass, uint_fast8_t > elfdata, >whi

Re: [PATCH 2/2] link_map: Pull read_addrs() into file scope

Hi Timm, On Mon, 2020-12-07 at 12:11 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. The whole idea behind using nested functions is that we don't need to pass around 9 arguments... But ok, it looks harmless. Pushed. Cheers, Mark

[PATCH] Remove unused Makefile variable GCC_INCLUDE

It appears to be unused since the first commit in the revision history. Signed-off-by: Dmitry V. Levin --- libasm/ChangeLog | 4 libasm/Makefile.am | 1 - libelf/ChangeLog | 4 libelf/Makefile.am | 2 +- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libasm/ChangeLo

[PATCH] configure.ac: fix typo in error diagnostics

Fixes: da855fc9c ("Support building when fts and obstack aren't part of libc") Signed-off-by: Dmitry V. Levin --- ChangeLog| 4 configure.ac | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 71e80a25..563af0d2 100644 --- a/ChangeLog +++ b/C

[PATCH] configure.ac: simplify argp check

Rewrite argp check using the same AC_SEARCH_LIBS based method used earlier in the fts check. Signed-off-by: Dmitry V. Levin --- ChangeLog| 2 ++ configure.ac | 31 --- 2 files changed, 10 insertions(+), 23 deletions(-) diff --git a/ChangeLog b/ChangeLog index 56

[PATCH] Remove unused tests/configure.ac

tests/configure.ac was introduced 15 years ago by commit d7f8d0caa7a357f9f4765e5dc93255f5057eba2e. However, the ability to build tests as a separate project was broken by the same author 4 years later by commit 22359e265395fd2f8267190ef97f5417770e6206, if not earlier. An attempt to run autoreconf