Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-04 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Something like this? > -DEBUGINFOD_URLS="$DEBUGINFOD_URLS @DEBUGINFOD_URLS@" > -export DEBUGINFOD_URLS > +if [ -n "@DEBUGINFOD_URLS@" ]; then > + DEBUGINFOD_URLS="${DEBUGINFOD_URLS-}${DEBUGINFOD_URLS:+ > }@DEBUGINFOD_URLS@" > + export DEBUGINFOD_URLS > +fi You took the words righ

Re: multi debug files and artificial module

2020-11-04 Thread Mark Wielaard
Hi Sasha, On Tue, 2020-11-03 at 21:37 +, Sasha Da Rocha Pinheiro via Elfutils-devel wrote: > we are currently dealing with multiple separate debug files, the > normal stripped ones put in .debug/ folder and now the ones generated > by DWZ and put into .dwz/ folder. > When loading a normal stri

[PATCH 2/1] config: do not define DEBUGINFOD_URLS environment variable unnecessarily

2020-11-04 Thread Dmitry V. Levin
Before this change, when elfutils was configured without --enable-debuginfod-urls, the installed profile.d/debuginfod.sh and profile.d/debuginfod.csh scripts used to define the DEBUGINFOD_URLS environment variable as an non-empty string containing spaces, making all libdebuginfod users do extra wor

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-04 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > > YES PLEASE! :-) > > > > As a transition, how about ChangeLog format content in the git commit > > messages? > > You mean as done by GCC? Not have actual ChangeLog files, but add the > ChangeLog entries themselves in the commit message? > https://gcc.gnu.org/codingconventions.html#Change