Re: [PATCH 1/2 v2] Don't overflow in __libdw_in_section

2017-12-20 Thread Mark Wielaard
On Thu, 2017-12-14 at 14:55 +0100, Ulf Hermann wrote: > On 12/14/2017 02:43 PM, Mark Wielaard wrote: > > The transformation seems correct. But if we can overflow/underflow > > here, do we have the same problem in __libdw_offset_in_section > > where we > >   check data->d_size - offset < size, with

Re: [PATCH 2/2 v2] Generalize cu_sec_idx

2017-12-20 Thread Mark Wielaard
On Thu, 2017-12-14 at 14:53 +0100, Ulf Hermann wrote: > On 12/14/2017 02:51 PM, Mark Wielaard wrote: > > This is clever and indeed cu_sec_idx () is not generic enough. > > But this is also somewhat inefficient. I am working on DWARF5 support > > and there a CU can come from even more different sect