Re: patch 5 debuginfod: prometheus metrics

2019-11-19 Thread Mark Wielaard
Hi, On Mon, 2019-11-18 at 11:47 -0500, Frank Ch. Eigler wrote: > > > > > +control. The \fI/metrics\fP webapi endpoint is probably not > > > > > +appropriate for disclosure to the public. > > > > > > > > So, should there be an option to turn it off? > > > > > > IMHO not necessary. The security

Re: patch 5 debuginfod: prometheus metrics

2019-11-18 Thread Frank Ch. Eigler
Hi - > > > see it is already in a comment in the code. Best to also add it as See > > > also in the docs. > > > > OK. > > Thanks, that would be good. Done. > > > > +control. The \fI/metrics\fP webapi endpoint is probably not > > > > +appropriate for disclosure to the public. > > > > > > So,

Re: patch 5 debuginfod: prometheus metrics

2019-11-18 Thread Mark Wielaard
Hi, On Fri, 2019-11-15 at 12:57 -0500, Frank Ch. Eigler wrote: > Could you also add a reference to the Prometheus Exposition format. I > > see it is already in a comment in the code. Best to also add it as See > > also in the docs. > > OK. Thanks, that would be good. > > > +control. The \fI/me

Re: patch 5 debuginfod: prometheus metrics

2019-11-15 Thread Frank Ch. Eigler
Hi - > Could you also add a reference to the Prometheus Exposition format. I > see it is already in a comment in the code. Best to also add it as See > also in the docs. OK. > > +control. The \fI/metrics\fP webapi endpoint is probably not > > +appropriate for disclosure to the public. > > So,

Re: patch 5 debuginfod: prometheus metrics

2019-11-15 Thread Mark Wielaard
Hi, On Thu, 2019-11-07 at 04:08 -0500, Frank Ch. Eigler wrote: > This webapi extensions allows admins to hook up debuginfod to a > prometheus-compatible monitoring system for general situational > statistics. The metrics are simple enough that local curl requests > can give a user a sense of what

patch 5 debuginfod: prometheus metrics

2019-11-07 Thread Frank Ch. Eigler
From: "Frank Ch. Eigler" Date: Thu, 7 Nov 2019 04:00:16 -0500 Subject: [PATCH 2/2] debuginfod 5: add /metrics endpoint This webapi extensions allows admins to hook up debuginfod to a prometheus-compatible monitoring system for general situational statistics. The metrics are simple enough that