Re: patch 0/2 debuginfod submission

2019-10-31 Thread Mark Wielaard
Hi Frank, On Wed, 2019-10-30 at 14:11 -0400, Frank Ch. Eigler wrote: > Revised code to look like this (libdwfl/find-debuginfo.c): > > 00404 /* NB: this is slightly thread-unsafe */ > 00405 static __typeof__ (debuginfod_find_debuginfo) > *fp_debuginfod_find_debuginfo; > 00406 > 00407

Re: patch 0/2 debuginfod submission

2019-10-30 Thread Frank Ch. Eigler
Hi - > Ah, I was not thinking that far yet. I was just worried about the > dlopen/dlsym dance being done on every call. Which does its own file > search to find the library. So simply setting debuginfod_so = (void *) > -1; on first failure to make sure dlopen/dlsym it is never called > again. Rev

Re: patch 0/2 debuginfod submission

2019-10-30 Thread Mark Wielaard
Hi Frank, On Wed, 2019-10-30 at 09:40 -0400, Frank Ch. Eigler wrote: > OK, sure, IMO don't even bother with a guard. It's just a dlopen/dlsym, > which is portable. Will update the first patch on the branch with that. Thanks. > > Also I think you should cache a negative result for > > fp_debugi

Re: patch 0/2 debuginfod submission

2019-10-30 Thread Frank Ch. Eigler
Hi, Mark - > I only browsed through the code quickly, but I like what I see. > For now just a comment on the libdwfl integration. Righto. > It is guarded by ENABLE_DEBUGINFOD, which is off by default. > I think the support should always be enabled in libdwfl whether or not > the debuginfod ser

Re: patch 0/2 debuginfod submission

2019-10-30 Thread Mark Wielaard
Hi Frank, Hi Aaron, On Mon, 2019-10-28 at 15:04 -0400, Frank Ch. Eigler wrote: > Aaron Merey and I would like to propose debuginfod for merge into > elfutils mainline, after a couple of months of work. As a reminder, > this is an http server (written in C++11) for debuginfo-related > artifacts (e

patch 0/2 debuginfod submission

2019-10-28 Thread Frank Ch. Eigler
Hi - Aaron Merey and I would like to propose debuginfod for merge into elfutils mainline, after a couple of months of work. As a reminder, this is an http server (written in C++11) for debuginfo-related artifacts (elf/dwarf/source files), plus a C client library & command line tool. It comes wit