Re: patch: debuginfod sqlite3 metrics

2020-11-26 Thread Mark Wielaard
On Wed, Nov 25, 2020 at 12:50:18PM -0500, Frank Ch. Eigler via Elfutils-devel wrote: > Hi - > > > Looks good. Just one question about the RAII timing metrics. > > It is using gettimeofday which I believe might jump around since it > > tracks "human time". Might it be better to use clock_gettime >

Re: patch: debuginfod sqlite3 metrics

2020-11-25 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Looks good. Just one question about the RAII timing metrics. > It is using gettimeofday which I believe might jump around since it > tracks "human time". Might it be better to use clock_gettime > (CLOCK_MONOTONIC) instead? Note that uses nanoseconds instead of > microseconds, so needs adjus

Re: patch: debuginfod sqlite3 metrics

2020-11-25 Thread Mark Wielaard
Hi Frank, On Mon, 2020-11-23 at 20:07 -0500, Frank Ch. Eigler via Elfutils-devel wrote: > From 0b61f4c758a507fcc2243357363e44140bd13d82 Mon Sep 17 00:00:00 > 2001 ?!??!! > From: "Frank Ch. Eigler" > Date: Mon, 23 Nov 2020 19:58:10 -0500 > Subject: [PATCH] debuginfod:

patch: debuginfod sqlite3 metrics

2020-11-23 Thread Frank Ch. Eigler via Elfutils-devel
Hi - >From 0b61f4c758a507fcc2243357363e44140bd13d82 Mon Sep 17 00:00:00 2001 ?!??!! From: "Frank Ch. Eigler" Date: Mon, 23 Nov 2020 19:58:10 -0500 Subject: [PATCH] debuginfod: sqlite3 metrics Add metrics for tracking sqlite3 error counts and query performance. The former loo