Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-24 Thread Mark Wielaard
On Thu, 2017-11-23 at 09:39 +0100, Dodji Seketeli wrote: > Indeed, thank you or doing this.  I wish I had these facilities sooner > when I was tracking the cause of my issues.  So no doubt this work is > going to be useful. Thanks. I pushed my second variant to master now. Cheers, Mark

Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-23 Thread Dodji Seketeli
Sorry for my late reply, Tom Tromey a écrit: >> "Mark" == Mark Wielaard writes: > > Mark> This has been really useful to debug some DWARF format issues, but it > Mark> could be even more useful. Since we know the attribute name and form > Mark> (or we would have generated an error earlier)

Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-22 Thread Mark Wielaard
On Tue, 2017-11-21 at 11:21 +0100, Mark Wielaard wrote: > On Thu, 2017-11-16 at 15:31 +0100, Mark Wielaard wrote: > > On Tue, 2017-10-03 at 16:59 +0200, Mark Wielaard wrote: > > > When processing large files it is useful to know the DIE offset if > > > printing of attributes fails (especially when

Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-22 Thread Mark Wielaard
On Tue, 2017-11-21 at 12:19 -0700, Tom Tromey wrote: > > > > > > "Mark" == Mark Wielaard writes: > > Mark> This has been really useful to debug some DWARF format issues, but it > Mark> could be even more useful. Since we know the attribute name and form > Mark> (or we would have generated an erro

Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-21 Thread Tom Tromey
> "Mark" == Mark Wielaard writes: Mark> This has been really useful to debug some DWARF format issues, but it Mark> could be even more useful. Since we know the attribute name and form Mark> (or we would have generated an error earlier) add those to the error Mark> message too. Thanks for do

Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-21 Thread Mark Wielaard
On Thu, 2017-11-16 at 15:31 +0100, Mark Wielaard wrote: > On Tue, 2017-10-03 at 16:59 +0200, Mark Wielaard wrote: > > When processing large files it is useful to know the DIE offset if > > printing of attributes fails (especially when redirecting the output). > > With this change the error message

Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-16 Thread Mark Wielaard
On Tue, 2017-10-03 at 16:59 +0200, Mark Wielaard wrote: > When processing large files it is useful to know the DIE offset if > printing of attributes fails (especially when redirecting the output). > With this change the error message looks like: > >   eu-readelf: DIE [2aeb8ef1] cannot get attribu