Re: [PATCH] PR32218: debuginfod-client: support very long source file

2024-10-16 Thread Mark Wielaard
Hi Frank, On Tue, 2024-10-15 at 18:12 -0400, Frank Ch. Eigler wrote: > > Is this 4-byte hash enough to prevent accidental collisions? > > Yeah, it only needs to be uniqueish among source files of the same > binary, and with the same #-escaped tail string. Aha, it is "under" an unique build-id al

Re: [PATCH] PR32218: debuginfod-client: support very long source file

2024-10-15 Thread Frank Ch. Eigler
Hi - > Hi Frank, Thanks for the review. > Maybe add the bugzilla URL as an example of this. > I see it is in the subject, but it is nice to just click on something. Done. > [...] > Is this 4-byte hash enough to prevent accidental collisions? Yeah, it only needs to be uniqueish among source fi

Re: [PATCH] PR32218: debuginfod-client: support very long source file

2024-10-15 Thread Mark Wielaard
Hi Frank, On Thu, 2024-10-10 at 17:24 -0400, Frank Ch. Eigler wrote: > From be79d138989b9968f9c687ef62cc91b5b93e32b5 Mon Sep 17 00:00:00 2001 > From: "Frank Ch. Eigler" > Date: Thu, 10 Oct 2024 16:30:19 -0400 > Subject: [PATCH] PR32218: debuginfod-client: support very long source file > names >