Re: [PATCH] Handle DW_AT_decl_file 0

2024-02-12 Thread Aaron Merey
Hi Mark, On Mon, Feb 12, 2024 at 4:14 PM Mark Wielaard wrote: > > On Mon, Feb 12, 2024 at 01:16:30PM -0500, Aaron Merey wrote: > > On Mon, Feb 12, 2024 at 12:31 PM Mark Wielaard wrote: > > > >(void) INTUSE(dwarf_getsrclines) (&CUDIE (cu), &lines, &nlines); > > > > - assert (cu->line

Re: [PATCH] Handle DW_AT_decl_file 0

2024-02-12 Thread Mark Wielaard
Hi Aaron, On Mon, Feb 12, 2024 at 01:16:30PM -0500, Aaron Merey wrote: > On Mon, Feb 12, 2024 at 12:31 PM Mark Wielaard wrote: > > >(void) INTUSE(dwarf_getsrclines) (&CUDIE (cu), &lines, &nlines); > > > - assert (cu->lines != NULL); > > > } > > > > I see why would like to get ri

Re: [PATCH] Handle DW_AT_decl_file 0

2024-02-12 Thread Aaron Merey
Hi Mark, On Mon, Feb 12, 2024 at 12:31 PM Mark Wielaard wrote: > >(void) INTUSE(dwarf_getsrclines) (&CUDIE (cu), &lines, &nlines); > > - assert (cu->lines != NULL); > > } > > I see why would like to get rid of asserts in the code base. > But I believe the assert is valid. dwarf_

Re: [PATCH] Handle DW_AT_decl_file 0

2024-02-12 Thread Mark Wielaard
Hi Aaron, On Fri, 2024-02-09 at 21:52 -0500, Aaron Merey wrote: > Modify dwarf_decl_file to support DW_AT_decl_file with value 0. > > Because of inconsistencies in the DWARF 5 spec, it is ambiguous whether > DW_AT_decl_file value 0 is a valid .debug_line file table index for the > main source fil