Re: [PATCH] Fix leb128 reading

2020-10-27 Thread Mark Wielaard
Hi Tom, On Mon, 2020-10-26 at 16:54 -0600, Tom Tromey wrote: > > > In this patch, I chose to try to handle weird leb128 encodings by > > > preserving their values when possible; or returning the maximum value > > > on overflow. It isn't clear to me that this is necessarily the best > > > choice.

Re: [PATCH] Fix leb128 reading

2020-10-26 Thread Tom Tromey
>> In this patch, I chose to try to handle weird leb128 encodings by >> preserving their values when possible; or returning the maximum value >> on overflow. It isn't clear to me that this is necessarily the best >> choice. Mark> I think it is a good thing to accept "padded" leb128 numbers, but M

Re: [PATCH] Fix leb128 reading

2020-10-24 Thread Mark Wielaard
Hi Tom, On Fri, Oct 23, 2020 at 09:58:34PM -0600, Tom Tromey wrote: > PR 26773 points out that some sleb128 values are decoded incorrectly. > Looking into this, I found some other unusual cases as well. > > In this patch, I chose to try to handle weird leb128 encodings by > preserving their value