Re: PR25369 slice 3/3: debuginfod header relay

2020-03-29 Thread Mark Wielaard
Hi Frank, On Fri, 2020-03-27 at 09:59 -0400, Frank Ch. Eigler wrote: > I don't think it is a scare story to explicitly say: "Note that the > > current implementation uses libcurl, but you shouldn't rely on that > > fact. The only supported usage of this method is for adding an > > optional header

Re: PR25369 slice 3/3: debuginfod header relay

2020-03-27 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > > I guess I don't see a problem here. HTTP request headers are by > > definition optional things. How it's used --- why would we want to > > dictate "only ... for" anything? We do what we do. > > But what we do is technically just pass the given string to curl as is. > It is just that

Re: PR25369 slice 3/3: debuginfod header relay

2020-03-27 Thread Mark Wielaard
Hi Frank, On Thu, 2020-03-26 at 18:54 -0400, Frank Ch. Eigler wrote: > > Normally a user client doesn't really need to know much about whether > > or how the file information is fetched. But in this case we have a http > > transport specific thing (and we just added support for file:// URLs). > >

Re: PR25369 slice 3/3: debuginfod header relay

2020-03-26 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I see how this is useful for logging what is going on in the debuginfod > server. And even how some client program might want to set the User- > Agent itself. But it feels a bit like a hack to make this a public API > for the client library. Sure. > Normally a user client doesn't really n

Re: PR25369 slice 3/3: debuginfod header relay

2020-03-26 Thread Mark Wielaard
Hi Frank, On Tue, 2020-03-24 at 23:49 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > This is the last of three bits for the month-ago PR25369 patchset. > > Author: Frank Ch. Eigler > Date: Tue Mar 24 23:46:30 2020 -0400 > > debuginfod: User-Agent and X-Forwarded-For header relay >

PR25369 slice 3/3: debuginfod header relay

2020-03-24 Thread Frank Ch. Eigler via Elfutils-devel
Hi - This is the last of three bits for the month-ago PR25369 patchset. Author: Frank Ch. Eigler Date: Tue Mar 24 23:46:30 2020 -0400 debuginfod: User-Agent and X-Forwarded-For header relay Extend the debuginfod client API with a function to stuff outgoing headers into libcur