Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-28 Thread Luca Boccassi
On Mon, 2022-03-28 at 11:57 +0200, Mark Wielaard wrote: > Hi Luca, > > On Sat, 2022-03-26 at 18:19 +, Luca Boccassi wrote: > > > Already working on the updated script, the native type is exactly > > > the > > > approach I was taking, this works fine on a Debian machine on s390x > > > (and also

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-28 Thread Mark Wielaard
Hi Luca, On Sat, 2022-03-26 at 18:19 +, Luca Boccassi wrote: > > Already working on the updated script, the native type is exactly > > the > > approach I was taking, this works fine on a Debian machine on s390x > > (and also on x86_64), eg: > > > > -BYTE(0x04) BYTE(0x00) BYTE(0x00) BY

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-26 Thread Luca Boccassi
On Sat, 2022-03-26 at 16:57 +, Luca Boccassi wrote: > On Sat, 2022-03-26 at 17:33 +0100, Mark Wielaard wrote: > > Hi Luca, > > > > On Fri, Mar 25, 2022 at 02:55:14PM +, Luca Boccassi wrote: > > > On Fri, 2022-03-25 at 15:47 +0100, Mark Wielaard wrote: > > > > > We have completely overlooke

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-26 Thread Luca Boccassi
On Sat, 2022-03-26 at 17:33 +0100, Mark Wielaard wrote: > Hi Luca, > > On Fri, Mar 25, 2022 at 02:55:14PM +, Luca Boccassi wrote: > > On Fri, 2022-03-25 at 15:47 +0100, Mark Wielaard wrote: > > > > We have completely overlooked that, the note is created by a > > > > linker > > > > script, whic

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-26 Thread Mark Wielaard
Hi Luca, On Fri, Mar 25, 2022 at 02:55:14PM +, Luca Boccassi wrote: > On Fri, 2022-03-25 at 15:47 +0100, Mark Wielaard wrote: > > > We have completely overlooked that, the note is created by a linker > > > script, which is generated at build time by this: > > > > > > https://github.com/system

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-25 Thread Luca Boccassi
On Fri, 2022-03-25 at 15:47 +0100, Mark Wielaard wrote: > Hi Luca, > > On Fri, 2022-03-25 at 13:52 +, Luca Boccassi wrote: > > On Fri, 2022-03-25 at 14:39 +0100, Mark Wielaard wrote: > > > But I noticed an issue on s390x fedora 36. > > > This isn't just elfutils though, binutils also has troub

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-25 Thread Mark Wielaard
Hi Luca, On Fri, 2022-03-25 at 13:52 +, Luca Boccassi wrote: > On Fri, 2022-03-25 at 14:39 +0100, Mark Wielaard wrote: > > But I noticed an issue on s390x fedora 36. > > This isn't just elfutils though, binutils also has trouble: > > > > Displaying notes found in: .note.package > > Owner

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-25 Thread Luca Boccassi
On Fri, 2022-03-25 at 14:39 +0100, Mark Wielaard wrote: > Hi Luca, > > On Fri, 2022-03-25 at 11:17 +, Luca Boccassi wrote: > > On Fri, 2022-03-25 at 00:14 +0100, Mark Wielaard wrote: > > > I took the elf.h update separately. Tweaked your patch a little and > > > added a patch of my own to make

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-25 Thread Mark Wielaard
Hi Luca, On Fri, 2022-03-25 at 11:17 +, Luca Boccassi wrote: > On Fri, 2022-03-25 at 00:14 +0100, Mark Wielaard wrote: > > I took the elf.h update separately. Tweaked your patch a little and > > added a patch of my own to make elflint recognize the new note > > type. > > > > [PATCH 1/3] lib

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-25 Thread Luca Boccassi
On Fri, 2022-03-25 at 00:14 +0100, Mark Wielaard wrote: > > I haven't forgotten about this. The glibc elf.h change has been > > integrated now. But when I wanted to resync with the elfutils > > libelf/elf.h version I noticed something that look like ABI > > breakage: > > https://sourceware.org/pipe

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2022-03-24 Thread Mark Wielaard
> I haven't forgotten about this. The glibc elf.h change has been > integrated now. But when I wanted to resync with the elfutils > libelf/elf.h version I noticed something that look like ABI > breakage: > https://sourceware.org/pipermail/libc-alpha/2021-December/133589.html > > I am trying to get

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-12-05 Thread Mark Wielaard
Hi Luca, On Tue, Nov 30, 2021 at 12:25:41PM +0100, Mark Wielaard wrote: > On Thu, 2021-11-25 at 17:02 +, Luca Boccassi via Elfutils-devel > wrote: > > +/* Packaging metadata as defined on > > > https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ > > > +#define FDO_PACKAGING_METADATA 0xcafe1a7e >

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-12-02 Thread Florian Weimer via Elfutils-devel
* Frank Ch. Eigler: >> > Yes, and yet we have had the bidi situation recently where UTF-8 raw >> > codes could visually confuse a human reader whereas escaped \u >> > wouldn't. If we forbid \u unilaterally, we literally become >> > incompatible with JSON (RFC8259 7. String. "Any character

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-12-02 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > JSON has been targeted at the Windows/Java UTF-16 world, there is always > going to be a mismatch if you try to represent it in UTF-8 or anything > that doesn't have surrogate pairs. The JSON RFC8259 8.1 mandates UTF-8 encoding for situations like ours. > > Yes, and yet we have had the b

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-30 Thread Mark Wielaard
Hi, On Tue, Nov 30, 2021 at 05:49:58PM +0100, Florian Weimer wrote: > * Frank Ch. Eigler via Elfutils-devel: > > On Tue, Nov 30, 2021 at 12:25:41PM +0100, Mark Wielaard wrote: > >> [...] > >> The spec does explain the requirements for JSON numbers, but doesn't > >> mention any for JSON strings or

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-30 Thread Florian Weimer via Elfutils-devel
* Frank Ch. Eigler via Elfutils-devel: > Hi - > > On Tue, Nov 30, 2021 at 12:25:41PM +0100, Mark Wielaard wrote: >> [...] >> The spec does explain the requirements for JSON numbers, but doesn't >> mention any for JSON strings or JSON objects. It would be good to also >> explain how to make the str

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-30 Thread Frank Ch. Eigler via Elfutils-devel
Hi - On Tue, Nov 30, 2021 at 12:25:41PM +0100, Mark Wielaard wrote: > [...] > The spec does explain the requirements for JSON numbers, but doesn't > mention any for JSON strings or JSON objects. It would be good to also > explain how to make the strings and objects unambiguous. [...] > For Objects

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-30 Thread Luca Boccassi via Elfutils-devel
On Tue, 2021-11-30 at 12:25 +0100, Mark Wielaard wrote: > Hi Luca, > > On Thu, 2021-11-25 at 17:02 +, Luca Boccassi via Elfutils-devel > wrote: > > +/* Packaging metadata as defined on > > > https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ > > > +#define FDO_PACKAGING_METADATA 0xcafe1a7e > >

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-30 Thread Mark Wielaard
Hi Luca, On Thu, 2021-11-25 at 17:02 +, Luca Boccassi via Elfutils-devel wrote: > +/* Packaging metadata as defined on > > https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ > > +#define FDO_PACKAGING_METADATA 0xcafe1a7e > > + > > /* Note section name of program property. */ > > #define NOT

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-25 Thread Luca Boccassi via Elfutils-devel
On Sun, 2021-11-21 at 19:43 +, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > this note will be used starting from Fedora 36. Allow > readelf --notes to pretty print it: > > Note section [ 3] '.note.package' of 76 bytes

[PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-21 Thread luca.boccassi--- via Elfutils-devel
From: Luca Boccassi As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ this note will be used starting from Fedora 36. Allow readelf --notes to pretty print it: Note section [ 3] '.note.package' of 76 bytes at offset 0x2e8: Owner Data size Type FDO 57 F