Re: [PATCH v2] libdwfl: use GNU strerror_r only when available.

2021-02-05 Thread Dmitry V. Levin
On Fri, Feb 05, 2021 at 03:46:42PM +0100, Mark Wielaard wrote: > On Tue, 2021-02-02 at 05:56 +0300, Dmitry V. Levin wrote: > > On Mon, Feb 01, 2021 at 09:16:56PM -0300, Érico Nogueira via Elfutils-devel > > wrote: > > [...] > > > I'm not sure if it's a bug in this configure.ac or this macro, but >

Re: [PATCH v2] libdwfl: use GNU strerror_r only when available.

2021-02-05 Thread Mark Wielaard
On Tue, 2021-02-02 at 05:56 +0300, Dmitry V. Levin wrote: > On Mon, Feb 01, 2021 at 09:16:56PM -0300, Érico Nogueira via Elfutils-devel > wrote: > [...] > > I'm not sure if it's a bug in this configure.ac or this macro, but > > _GNU_SOURCE wasn't defined and lead to XSI strerror_r being used on >

Re: [PATCH v2] libdwfl: use GNU strerror_r only when available.

2021-02-01 Thread Dmitry V. Levin
Hi, On Mon, Feb 01, 2021 at 09:16:56PM -0300, Érico Nogueira via Elfutils-devel wrote: [...] > I'm not sure if it's a bug in this configure.ac or this macro, but > _GNU_SOURCE wasn't defined and lead to XSI strerror_r being used on > glibc until I added the trick with CFLAGS and old_CFLAGS. It's

[PATCH v2] libdwfl: use GNU strerror_r only when available.

2021-02-01 Thread Érico Nogueira via Elfutils-devel
From: Érico Rolim Some C libraries don't provide the GNU version of strerror_r, only the XSI-compliant one. We use the GNU version when available, since it fits the code better, and otherwise use the XSI-compliant one. https://sourceware.org/bugzilla/show_bug.cgi?id=21010 Signed-off-by: Érico R